Re: [HACKERS] ALTER .. OWNER TO error mislabels schema as other object type

2013-01-07 Thread Robert Haas
On Wed, Jan 2, 2013 at 10:35 AM, Kohei KaiGai wrote: > The attached patch fixes this trouble. Thanks. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t

Re: [HACKERS] ALTER .. OWNER TO error mislabels schema as other object type

2013-01-02 Thread Kohei KaiGai
Sorry, I oversight this report. The reason of this confusing error message is originated by incorrect aclkind being delivered to aclcheck_error() at AlterObjectOwner_internal(). /* New owner must have CREATE privilege on namespace */ if (OidIsValid(namespaceId))

Re: [HACKERS] ALTER .. OWNER TO error mislabels schema as other object type

2012-12-20 Thread Robert Haas
On Thu, Dec 20, 2012 at 11:46 AM, Tom Lane wrote: > Robert Haas writes: >> This looks busted: > > Between this and your previous example, it's becoming clear that the > recent refactorings of the ALTER code were not ready for prime time. > Perhaps we should just revert those instead of playing bu

Re: [HACKERS] ALTER .. OWNER TO error mislabels schema as other object type

2012-12-20 Thread Tom Lane
Robert Haas writes: > This looks busted: Between this and your previous example, it's becoming clear that the recent refactorings of the ALTER code were not ready for prime time. Perhaps we should just revert those instead of playing bug whack-a-mole. regards, tom lane

[HACKERS] ALTER .. OWNER TO error mislabels schema as other object type

2012-12-20 Thread Robert Haas
This looks busted: rhaas=# create role clerks; CREATE ROLE rhaas=# create role bob in role clerks; CREATE ROLE rhaas=# create schema foo; CREATE SCHEMA rhaas=# grant usage on schema foo to bob, clerks; GRANT rhaas=# create aggregate foo.sum(basetype=text,sfunc=textcat,stype=text,initcond=''); CREA