Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT

2004-11-14 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > OK, Tom please go ahead with the patch. Done. regards, tom lane ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT

2004-11-13 Thread Bruce Momjian
Andrew McMillan wrote: > > > That sounds excellent - I hadn't realised that this workaround would be > > > possible, and indeed with this in place that will provide even better > > > control over the facility. > > > > OK, here is one vote for the ALTER USER/remove USERLIMIT croud, and you > > were

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT

2004-11-13 Thread Andrew McMillan
On Thu, 2004-11-11 at 23:05 -0500, Bruce Momjian wrote: > Andrew McMillan wrote: > -- Start of PGP signed section. > > On Wed, 2004-11-10 at 11:45 -0500, Tom Lane wrote: > > > Andrew McMillan <[EMAIL PROTECTED]> writes: > > > > When tracking down gnarly problems in heavily multi-user applications >

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT

2004-11-11 Thread Bruce Momjian
Andrew McMillan wrote: -- Start of PGP signed section. > On Wed, 2004-11-10 at 11:45 -0500, Tom Lane wrote: > > Andrew McMillan <[EMAIL PROTECTED]> writes: > > > When tracking down gnarly problems in heavily multi-user applications > > > enabling higher log levels at selective points has the potent

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT

2004-11-11 Thread Andrew McMillan
On Wed, 2004-11-10 at 11:45 -0500, Tom Lane wrote: > Andrew McMillan <[EMAIL PROTECTED]> writes: > > When tracking down gnarly problems in heavily multi-user applications > > enabling higher log levels at selective points has the potential to help > > _a lot_ with diagnostic detail, without smother

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable category

2004-11-10 Thread Greg Stark
Stephan Szabo <[EMAIL PROTECTED]> writes: > > Would that mean I wouldn't be able to change the logging level on the fly at > > all? > > I would think you'd still be able to do it through a security definer > wrapper function owned by a superuser. Oh yeah, well that would be sufficient for my pu

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable category

2004-11-10 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Tom Lane <[EMAIL PROTECTED]> writes: >> I'd like to propose that we get rid of GUC's USERLIMIT category and >> convert all the variables in it to plain SUSET. > Would that mean I wouldn't be able to change the logging level on the fly at > all? No, it woul

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable category

2004-11-10 Thread Tom Lane
Andrew McMillan <[EMAIL PROTECTED]> writes: > When tracking down gnarly problems in heavily multi-user applications > enabling higher log levels at selective points has the potential to help > _a lot_ with diagnostic detail, without smothering you in _every_ > detail. Sure. As I pointed out in th

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable

2004-11-10 Thread Stephan Szabo
On Tue, 10 Nov 2004, Greg Stark wrote: > > Tom Lane <[EMAIL PROTECTED]> writes: > > > I'd like to propose that we get rid of GUC's USERLIMIT category and > > convert all the variables in it to plain SUSET. In my mind, USERLIMIT > > is a failed experiment: it's way too complicated, and it still do

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT

2004-11-10 Thread Andrew McMillan
On Tue, 2004-11-09 at 17:27 -0500, Tom Lane wrote: > > What the USERLIMIT code tries to do is allow non-superusers to > "increase" but not "decrease" the logging verbosity for their sessions > only. (For instance, a non-superuser could turn log_duration on, but > can't turn it off if the DBA has

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable

2004-11-09 Thread Bruce Momjian
Greg Stark wrote: > > Tom Lane <[EMAIL PROTECTED]> writes: > > > I'd like to propose that we get rid of GUC's USERLIMIT category and > > convert all the variables in it to plain SUSET. In my mind, USERLIMIT > > is a failed experiment: it's way too complicated, and it still doesn't > > do quite w

Re: [HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable category

2004-11-09 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > I'd like to propose that we get rid of GUC's USERLIMIT category and > convert all the variables in it to plain SUSET. In my mind, USERLIMIT > is a failed experiment: it's way too complicated, and it still doesn't > do quite what it was intended to do, becau

[HACKERS] A modest proposal: get rid of GUC's USERLIMIT variable category

2004-11-09 Thread Tom Lane
I'd like to propose that we get rid of GUC's USERLIMIT category and convert all the variables in it to plain SUSET. In my mind, USERLIMIT is a failed experiment: it's way too complicated, and it still doesn't do quite what it was intended to do, because there are times when it can't check whether