Re: [HACKERS] A little pg_dump patch

2011-09-19 Thread Enrico Pirozzi
Ok, but with this hack I need 2 databases, one with comments and another without comments. I prefer to have only one db with comments and choice to have a dump with comments or without comments. regards, Enrico 2011/9/19 Greg Sabino Mullane : > > -BEGIN PGP SIGNED MESSAGE- > Hash: RIPEMD1

Re: [HACKERS] A little pg_dump patch

2011-09-19 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 >> I wrote this little patch, becuse my customer doesn't want to have >> comments on the production db. It's not my choice > > Then use pg_restore --use-list to filter them out, and you won't need a Or just strip them out after the fact with

Re: [HACKERS] A little pg_dump patch

2011-09-19 Thread Enrico Pirozzi
> Patching pg_dump like this seems like the wrong way to go. Ok ;) Thank you very much Enrico -- That's one small step for man; one giant leap for mankind -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/m

Re: [HACKERS] A little pg_dump patch

2011-09-19 Thread Andrew Dunstan
On 09/19/2011 11:23 AM, Enrico Pirozzi wrote: What's the use case for not dumping comments? At first glance it seems a very odd thing to do. I wrote this little patch, becuse my customer doesn't want to have comments on the production db. It's not my choice Then use pg_restore --use-lis

Re: [HACKERS] A little pg_dump patch

2011-09-19 Thread Enrico Pirozzi
> What's the use case for not dumping comments? At first glance it seems a > very odd thing to do. > > cheers > > andrew I wrote this little patch, becuse my customer doesn't want to have comments on the production db. It's not my choice Regards, Enrico -- That's one small step for man; on

Re: [HACKERS] A little pg_dump patch

2011-09-19 Thread Andrew Dunstan
On 09/19/2011 10:34 AM, Enrico Pirozzi wrote: Hi, I'm Enrico, I wrote a little pg_dump patch, I have introduced a new option to have a database dump without comments, no 'COMMENT ON' are written on the dump if my new option is selected. If this little piece of code can interest somebody, I'll

[HACKERS] A little pg_dump patch

2011-09-19 Thread Enrico Pirozzi
Hi, I'm Enrico, I wrote a little pg_dump patch, I have introduced a new option to have a database dump without comments, no 'COMMENT ON' are written on the dump if my new option is selected. If this little piece of code can interest somebody, I'll be happy to share it with the community, Regards,