On Wed, Sep 5, 2012 at 10:46:17PM -0400, Andrew Dunstan wrote:
>
> On 09/05/2012 10:41 PM, Bruce Momjian wrote:
> >
> >I would like to see a more verbose comment, so we don't forget why we
> >did this. I think my inability to quickly discover the cause of the
> >previous log write problem is tha
On 09/05/2012 10:41 PM, Bruce Momjian wrote:
I would like to see a more verbose comment, so we don't forget why we
did this. I think my inability to quickly discover the cause of the
previous log write problem is that I didn't document which file
descriptors are kept open on Windows. I sugges
On Wed, Sep 5, 2012 at 10:35:26PM -0400, Andrew Dunstan wrote:
> diff --git a/contrib/pg_upgrade/exec.c b/contrib/pg_upgrade/exec.c
> index 99f5006..f84d857 100644
> --- a/contrib/pg_upgrade/exec.c
> +++ b/contrib/pg_upgrade/exec.c
> @@ -63,7 +63,25 @@ exec_prog(const char *log_file, const char *o
On Wed, Sep 5, 2012 at 10:35:26PM -0400, Andrew Dunstan wrote:
> >>Icky. I wish there were some nice portable flock() mechanism we could use.
> >>
> >>I just re-ran the test on the same machine, same code, same
> >>everything as the reporte3d failure, and it passed, so it definitely
> >>looks like
On 09/05/2012 10:07 PM, Bruce Momjian wrote:
On Wed, Sep 5, 2012 at 10:04:07PM -0400, Andrew Dunstan wrote:
On 09/05/2012 09:42 PM, Bruce Momjian wrote:
On Wed, Sep 5, 2012 at 09:07:05PM -0400, Andrew Dunstan wrote:
OK, I worked with Andrew on this issue, and have applied the attached
patch
On Wed, Sep 5, 2012 at 10:04:07PM -0400, Andrew Dunstan wrote:
>
> On 09/05/2012 09:42 PM, Bruce Momjian wrote:
> >On Wed, Sep 5, 2012 at 09:07:05PM -0400, Andrew Dunstan wrote:
> >>>OK, I worked with Andrew on this issue, and have applied the attached
> >>>patch which explains what is happening
On 09/05/2012 09:42 PM, Bruce Momjian wrote:
On Wed, Sep 5, 2012 at 09:07:05PM -0400, Andrew Dunstan wrote:
OK, I worked with Andrew on this issue, and have applied the attached
patch which explains what is happening in this case. Andrew's #ifndef
WIN32 was the correct fix. I consider this i
On Wed, Sep 5, 2012 at 09:07:05PM -0400, Andrew Dunstan wrote:
> >OK, I worked with Andrew on this issue, and have applied the attached
> >patch which explains what is happening in this case. Andrew's #ifndef
> >WIN32 was the correct fix. I consider this issue closed.
> >
>
>
> It looks like w
On 09/05/2012 12:02 AM, Bruce Momjian wrote:
On Mon, Sep 3, 2012 at 12:44:09PM -0400, Andrew Dunstan wrote:
The attached very small patch allows pg_upgrade's "make check" to
succeed on REL9_2_STABLE on my Mingw system.
However, I consider the issue I mentioned earlier regarding use of
forward
On Mon, Sep 3, 2012 at 12:44:09PM -0400, Andrew Dunstan wrote:
> The attached very small patch allows pg_upgrade's "make check" to
> succeed on REL9_2_STABLE on my Mingw system.
>
> However, I consider the issue I mentioned earlier regarding use of
> forward slashes in the argument to rmdir to be
On 09/04/2012 09:47 AM, Bruce Momjian wrote:
On Mon, Sep 3, 2012 at 12:44:09PM -0400, Andrew Dunstan wrote:
The attached very small patch allows pg_upgrade's "make check" to
succeed on REL9_2_STABLE on my Mingw system.
However, I consider the issue I mentioned earlier regarding use of
forward
On Mon, Sep 3, 2012 at 12:44:09PM -0400, Andrew Dunstan wrote:
> The attached very small patch allows pg_upgrade's "make check" to
> succeed on REL9_2_STABLE on my Mingw system.
>
> However, I consider the issue I mentioned earlier regarding use of
> forward slashes in the argument to rmdir to be
I wrote:
> Andrew Dunstan writes:
>> No, go for it. I can sync up without difficulty. Does that include
>> backpatching the exec_prog changes to 9.2?
> Yes, nobody objected, so I'll do that too.
And done. Please apply the other open fixes to both HEAD and 9.2.
Should be easy at this point.
Andrew Dunstan writes:
> On 09/03/2012 12:58 PM, Tom Lane wrote:
>> My intentions over the next hour or two are to commit the
>> unix-socket-directory fix and then sync 9.2 pg_upgrade with HEAD
>> (ie, back-patch everything that's in HEAD except the int64-XLogRecPtr
>> changes). Will that cause a
On 09/03/2012 12:58 PM, Tom Lane wrote:
Andrew Dunstan writes:
The attached very small patch allows pg_upgrade's "make check" to
succeed on REL9_2_STABLE on my Mingw system.
However, I consider the issue I mentioned earlier regarding use of
forward slashes in the argument to rmdir to be a sign
Andrew Dunstan writes:
> The attached very small patch allows pg_upgrade's "make check" to
> succeed on REL9_2_STABLE on my Mingw system.
> However, I consider the issue I mentioned earlier regarding use of
> forward slashes in the argument to rmdir to be a significant blocker, so
> I'm going
The attached very small patch allows pg_upgrade's "make check" to
succeed on REL9_2_STABLE on my Mingw system.
However, I consider the issue I mentioned earlier regarding use of
forward slashes in the argument to rmdir to be a significant blocker, so
I'm going to go and fix that and then pull
17 matches
Mail list logo
