"Nicolai Tufar" <[EMAIL PROTECTED]> writes:
> Sorry for rising up old issue again but the problem still persists.
> And database cluster is not being created with Turkish locale
I've committed the attached fix, which I believe will solve this
problem. Could you test it?
(Patch is against 7.4 bra
> -Original Message-
> From: Tom Lane
> Did you try running the regression tests under tr_TR locale? It seems
> a few bricks short of "fine" yet :-(
I run regression tests under tr_TR locale. To do this I hardcoded
Turkish locale in initdb in pg_regress.sh. Three tests failed, I
attached
"Nicolai Tufar" <[EMAIL PROTECTED]> writes:
>> It looks to me like every use of strcasecmp in the backend has to be
>> questioned if we're going to make this work. I'm starting to lean in
>> the direction of "tr_TR is hopelessly broken" again...
> With this patch applied everything works fine. Th
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]
> Hmm. It seems that tr_TR has problems much more extensive than you've
> indicated previously. I was able to get through initdb with the
attached
> additional patch, but the regression tests fail in several places.
> It look
"Nicolai Tufar" <[EMAIL PROTECTED]> writes:
> Under locale-ignorant FreeBSD it works fine.
> But under Fedora Core 1 initdb it crashes under all
> locales I tested -C, en_US, tr_TR with message given below.
Hmm. It seems that tr_TR has problems much more extensive than you've
indicated previously
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]
>
> I've committed the attached fix, which I believe will solve this
> problem. Could you test it?
Thank you very much for your effort and attention!
I am not sure I am testing the right version. I am testing the
one with R
Sorry for rising up old issue again but the problem still persists.
And database cluster is not being created with Turkish locale
If you have any doubts about how Turkish users will react to the fact
that both "I" and "I WITH DOT" will be treated as same character, rest
assured that this behavior
Greg Stark <[EMAIL PROTECTED]> writes:
> But the example given was "SERIAL". "serial" is an English word, not a
> Turkish word. It shouldn't really be subject to Turkish locale effects
> at all.
SERIAL is not a keyword according to the grammar. Neither are PUBLIC,
VOID, INT4, and numerous other e
Tom Lane <[EMAIL PROTECTED]> writes:
> Greg Stark <[EMAIL PROTECTED]> writes:
> > If it matches an SQL keyword after being downcased the old fashioned way, then
> > it's an SQL keyword. If not then the locale-aware tolower() would be
> > appropriate for tables, columns, etc.
>
> That's exactly w
Greg Stark <[EMAIL PROTECTED]> writes:
> If it matches an SQL keyword after being downcased the old fashioned way, then
> it's an SQL keyword. If not then the locale-aware tolower() would be
> appropriate for tables, columns, etc.
That's exactly what we do already. The complaint was that the
loca
Tom Lane <[EMAIL PROTECTED]> writes:
> It seems to me that that's too narrow a definition of the problem.
> I think we should state our goal as "we don't want bizarre locale
> definitions to interfere with downcasing of the basic ASCII letters".
> If we put in a special case for 'I' we will fix t
"Tom Lane" [EMAIL PROTECTED] wrote:
>
>"Nicolai Tufar" <[EMAIL PROTECTED]> writes:
>>> A possible compromise is to apply ASCII downcasing (same as in
>>> keywords.c) for 7-bit-ASCII characters, and apply tolower() only
>>> for character codes above 127. In other words
>
>> If we go this way why no
"Nicolai Tufar" <[EMAIL PROTECTED]> writes:
>> A possible compromise is to apply ASCII downcasing (same as in
>> keywords.c) for 7-bit-ASCII characters, and apply tolower() only
>> for character codes above 127. In other words
> If we go this way why not make a special case only and only for 'I'
> I still don't much like having a locale-specific wart in the parser
> (and the code you give could not work anyway --- for starters, the
> first argument of setlocale is not a pointer).
Aw, I see, my code broken. I got confused by locale_.._asign()
family
if functions. Sure, first argument
"Nicolai Tufar" <[EMAIL PROTECTED]> writes:
>> We might think that the Turkish-locale problem Devrim Gunduz pointed out
>> is a must-fix, too. But I'm not convinced yet what to do about it.
> Here is a first try to fix what Devrim Gunduz talked about.
I still don't much like having a locale-spe
> We might think that the Turkish-locale problem Devrim Gunduz pointed out> is a must-fix, too. But I'm not convinced yet what to do about it.
Here is a first try
to fix what
Devrim Gunduz talked about.
Please be patient with me for
it is the first major patch
I submit and I realize tha
16 matches
Mail list logo
