On Fri, Jul 1, 2016 at 1:41 AM, Andreas Seltenreich wrote:
> Amit Kapila writes:
>> On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro
>> wrote:
>>> Or maybe just like this?
>>>
>>> - snapshot->subxip = snapshot->xip +
>>> serialized_snapshot->xcnt;
>>> + snapshot->subxip
Amit Kapila writes:
> On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro
> wrote:
>> Or maybe just like this?
>>
>> - snapshot->subxip = snapshot->xip + serialized_snapshot->xcnt;
>> + snapshot->subxip = ((TransactionId *) (snapshot + 1)) +
>> + seriali
On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro
wrote:
> On Fri, Jul 1, 2016 at 3:25 PM, Amit Kapila wrote:
>> On Fri, Jul 1, 2016 at 8:48 AM, Thomas Munro
>> wrote:
>>> If serialized_snapshot->xcnt == 0, then snapshot->xip never gets
>>> initialized to a non-NULL value. Then if serialized_snapsho
On Fri, Jul 1, 2016 at 3:25 PM, Amit Kapila wrote:
> On Fri, Jul 1, 2016 at 8:48 AM, Thomas Munro
> wrote:
>> If serialized_snapshot->xcnt == 0, then snapshot->xip never gets
>> initialized to a non-NULL value. Then if serialized_snapshot->subxcnt
>> > 0, we set snapshot->subxip = snapshot->xip
On Fri, Jul 1, 2016 at 8:48 AM, Thomas Munro
wrote:
>
> On Fri, Jul 1, 2016 at 2:17 PM, Michael Paquier
> wrote:
> > On Fri, Jul 1, 2016 at 6:26 AM, Andreas Seltenreich
wrote:
> >> #1 0x00822032 in RestoreSnapshot
(start_address=start_address@entry=0x7f2701d5a110 ) at snapmgr.c:2020
> >
On Fri, Jul 1, 2016 at 2:17 PM, Michael Paquier
wrote:
> On Fri, Jul 1, 2016 at 6:26 AM, Andreas Seltenreich
> wrote:
>> #1 0x00822032 in RestoreSnapshot
>> (start_address=start_address@entry=0x7f2701d5a110 > memory at address 0x7f2701d5a110>) at snapmgr.c:2020
>
> memcpy(snaps
On Fri, Jul 1, 2016 at 6:26 AM, Andreas Seltenreich wrote:
> #1 0x00822032 in RestoreSnapshot
> (start_address=start_address@entry=0x7f2701d5a110 memory at address 0x7f2701d5a110>) at snapmgr.c:2020
memcpy(snapshot->subxip, serialized_xids + serialized_snapshot->xcnt,
Running sqlsmith on a streaming slave (master as of f8c5855) is
inconspicuous as long as the master is idle. As soon as I start it on
the master as well, the standby frequently crashes in RestoreSnapshot.
It doesn't seem to be specific to the queries, as they don't trigger a
crash when re-run.
Ba
