Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2014-04-22 Thread Bruce Momjian
On Thu, Mar 27, 2014 at 06:03:24PM +0100, Christoph Berg wrote: > Re: Bruce Momjian 2013-12-04 <20131204151533.gb17...@momjian.us> > > On Mon, May 6, 2013 at 11:51:47PM -0700, Christoph Berg wrote: > > > "make check" supports EXTRA_REGRESS_OPTS to pass extra options to > > > pg_regress, but all th

Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2014-03-27 Thread Christoph Berg
Re: Bruce Momjian 2013-12-04 <20131204151533.gb17...@momjian.us> > On Mon, May 6, 2013 at 11:51:47PM -0700, Christoph Berg wrote: > > "make check" supports EXTRA_REGRESS_OPTS to pass extra options to > > pg_regress, but all the other places where pg_regress is used do not > > allow this. The attac

Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2013-12-09 Thread Tom Lane
Bruce Momjian writes: > OK, Christoph has provided a full set of tested patches back to 8.4. > Should I backpatch these? Peter says no, but two others say yes. It's hard to paint that as a bug fix, so I'd vote for HEAD only. regards, tom lane -- Sent via pgsql-hacker

Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2013-12-09 Thread Michael Paquier
On Tue, Dec 10, 2013 at 12:08 PM, Bruce Momjian wrote: > On Thu, Dec 5, 2013 at 09:52:27AM +0100, Christoph Berg wrote: >> > The change is sane in itself. It won't affect anyone who doesn't use >> > EXTRA_REGRESS_OPTS. Why would we want to make packagers do MORE >> > work? >> >> The patch has bee

Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2013-12-09 Thread Bruce Momjian
On Thu, Dec 5, 2013 at 09:52:27AM +0100, Christoph Berg wrote: > > The change is sane in itself. It won't affect anyone who doesn't use > > EXTRA_REGRESS_OPTS. Why would we want to make packagers do MORE > > work? > > The patch has been in the Debian/Ubuntu/apt.pg.o packages for some > time, for

Re: [HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2013-12-04 Thread Bruce Momjian
On Mon, May 6, 2013 at 11:51:47PM -0700, Christoph Berg wrote: > "make check" supports EXTRA_REGRESS_OPTS to pass extra options to > pg_regress, but all the other places where pg_regress is used do not > allow this. The attached patch adds EXTRA_REGRESS_OPTS to > Makefile.global.in (for contrib mo

[HACKERS] [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

2013-05-06 Thread Christoph Berg
"make check" supports EXTRA_REGRESS_OPTS to pass extra options to pg_regress, but all the other places where pg_regress is used do not allow this. The attached patch adds EXTRA_REGRESS_OPTS to Makefile.global.in (for contrib modules) and two more special Makefiles (isolation and pg_upgrade). The u