On Mon, Feb 17, 2014 at 11:29 AM, Alvaro Herrera
wrote:
> The pg_regress part is ugly. However, pg_regress is doing something
> unusual when starting postmaster itself, so the ugly coding to stop it
> seems to match. If we wanted to avoid the ugliness here, the right fix
> would be to use pg_ctl
On Tue, Feb 18, 2014 at 1:29 AM, Alvaro Herrera
wrote:
> MauMau escribió:
> The pg_regress part is ugly. However, pg_regress is doing something
> unusual when starting postmaster itself, so the ugly coding to stop it
> seems to match. If we wanted to avoid the ugliness here, the right fix
> woul
MauMau escribió:
> pg_ctl timed out waiting for the zombie postgres.
>
> maumau 19621 18849 0 15:21 pts/900:00:00 [postgres]
> maumau 20253 18849 0 15:22 pts/900:00:00
> /maumau/postgresql-9.4/src/test/regress/./tmp_check/install//maumau/pgsql/bin/pg_ctl
> stop -D /maumau/postgresql-9
From: "Ronan Dunklau"
There is no regression tests covering this bugfix, althought I don't know
if
it would be practical to implement them.
Thanks for reviewing the patch. I'm glad to know that it seems OK.
Unfortunately, the current regression test system cannot handle the testing
of pg_c
Le mardi 7 janvier 2014 17:05:03 Michael Paquier a écrit :
> On Sun, Jan 5, 2014 at 3:49 PM, MauMau wrote:
> > Could you confirm again and tell me what problem is happening?
>
> FWIW, I just quickly tested those two patches independently and got
> them correctly applied with patch -p1 < $PATCH on
On Sun, Jan 5, 2014 at 3:49 PM, MauMau wrote:
> Could you confirm again and tell me what problem is happening?
FWIW, I just quickly tested those two patches independently and got
them correctly applied with patch -p1 < $PATCH on master at edc4345.
They compiled and passed as well make check.
Regar
From: "Peter Eisentraut"
On 12/25/13, 6:40 AM, MauMau wrote:
pg_regress must wait for postgres to terminate by calling waitpid(),
because it invoked postgres directly. The attached
pg_regress_pg_stop.patch does this. If you like the combination of this
and the original fix for pg_ctl in one p
On 12/25/13, 6:40 AM, MauMau wrote:
> pg_regress must wait for postgres to terminate by calling waitpid(),
> because it invoked postgres directly. The attached
> pg_regress_pg_stop.patch does this. If you like the combination of this
> and the original fix for pg_ctl in one patch, please use
> pg
From: "Peter Eisentraut"
This patch breaks the regression tests:
xml ... ok
test stats... ok
== shutting down postmaster ==
pg_ctl: server does not shut down
pg_regress: could not stop postmaster: exit code was
On 12/5/13, 7:07 AM, MauMau wrote:
> From: "Tom Lane"
>> If you're going to do a postmaster_is_alive check, why bother with
>> repeated get_pgpid()?
>
> As I said yesterday, I removed get_pgpid() calls. I'll add this patch
> to 2014-1 commitfest this weekend if it is not committed until then.
T
From: "Tom Lane"
If you're going to do a postmaster_is_alive check, why bother with
repeated get_pgpid()?
As I said yesterday, I removed get_pgpid() calls. I'll add this patch to
2014-1 commitfest this weekend if it is not committed until then.
Regards
MauMau
pg_stop_fail_v2.patch
Descri
From: "Tom Lane"
I think the reason why it was coded like that was that we hadn't written
postmaster_is_alive() yet, or maybe we had but didn't want to trust it.
However, with the coding you have here, we're fully exposed to any failure
modes postmaster_is_alive() may have; so there's not a lot
"MauMau" writes:
> The problem occurs in the sequence below:
> 1. postmaster creates $PGDATA/postmaster.pid.
> 2. postmaster tries to resolve the value of listen_addresses to IP
> addresses. This took about 15 seconds in my failure scenario.
> 3. During 2, pg_ctl sends SIGTERM to postmaster.
>
Hello,
I've encountered a small bug and fixed it. I guess this occurs on all major
releases. I saw this happen on 9.2 and 9.4devel. Please find attached the
patch and commit this.
[Problem]
If I mistakenly set an invalid value to listen_addresses, say '-1', and
start the database server,
14 matches
Mail list logo
