On Sat, Dec 13, 2014 at 11:53 PM, Julien Rouhaud
wrote:
> I agree with you about the problems of the v2 patch I originally sent.
> I think this v3 is the right way of keeping track of .ready files, so
> it's ok for me. The v3 also still applies well on current head.
Simon got a good point mentioni
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Le 18/11/2014 08:36, Michael Paquier a écrit :
> On Wed, Oct 22, 2014 at 12:50 AM, Brightwell, Adam
> wrote:
>> Though, I would think that the general desire would be to keep
>> the patch relevant ONLY to the necessary changes. I would not
>> qualif
Hearing nothing from the original author, this patch that was in state
"Waiting on Author" for a couple of days is switched to "returned with
feedback".
Regards,
--
Michael
On 18 November 2014 06:20, Michael Paquier wrote:
> the DBA may want to know how long is the queue of WAL files
> waiting to be archived.
Agreed
> That's IMO something we simply forgot in the
> first implementation of pg_stat_archiver
That's not how it appears to me. ISTM that the information
On Wed, Oct 22, 2014 at 12:50 AM, Brightwell, Adam
wrote:
> Though, I would think that the general desire would be to keep the patch
> relevant ONLY to the necessary changes. I would not qualify making those
> types of changes as relevant, IMHO. I do think this is potential for
> cleanup, howeve
On Tue, Nov 18, 2014 at 5:47 AM, Simon Riggs wrote:
> On 21 August 2014 09:17, Julien Rouhaud wrote:
>
>> Track number of WAL files ready to be archived in pg_stat_archiver
>
> Would it be OK to ask what the purpose of this TODO item is?
>
> pg_stat_archiver already has a column for last_archived
On 21 August 2014 09:17, Julien Rouhaud wrote:
> Track number of WAL files ready to be archived in pg_stat_archiver
Would it be OK to ask what the purpose of this TODO item is?
pg_stat_archiver already has a column for last_archived_wal and
last_failed_wal, so you can already work out how many
Julien,
> Actually, I used the same loop as the archiver one (see
> backend/postmaster/pgarch.c, function pgarch_readyXlog) to get the exact
> same number of files.
>
Ah, I see.
> If we change it in this patch, it would be better to change it everywhere.
> What do you think ?
>
Hmm... I'd hav
On Tue, Oct 21, 2014 at 7:35 AM, Brightwell, Adam <
adam.brightw...@crunchydatasolutions.com> wrote:
> Julien,
>
> The following is an initial review:
>
>
Thanks for the review.
> * Applies cleanly to master (f330a6d).
> * Regression tests updated and pass, including 'check-world'.
> * Documenta
Julien,
The following is an initial review:
* Applies cleanly to master (f330a6d).
* Regression tests updated and pass, including 'check-world'.
* Documentation updated and builds successfully.
* Might want to consider replacing the following magic number with a
constant or perhaps calculated val
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Le 28/08/2014 05:58, Michael Paquier a écrit :
> On Thu, Aug 28, 2014 at 7:37 AM, Julien Rouhaud
> wrote:
>>
>> Attached v2 patch implements this approach. All the work is still
>> done in pg_stat_get_archiver, as I don't think that having a
>> spec
On Thu, Aug 28, 2014 at 7:37 AM, Julien Rouhaud
wrote:
>
> Attached v2 patch implements this approach. All the work is still done
> in pg_stat_get_archiver, as I don't think that having a specific
> function for that information would be really interesting.
Please be sure to add that to the next
Le 25/08/2014 19:00, Gilles Darold a écrit :
> Le 21/08/2014 10:17, Julien Rouhaud a écrit :
>> Hello,
>>
>> Attached patch implements the following TODO item :
>>
>> Track number of WAL files ready to be archived in pg_stat_archiver
>>
>> However, it will track the total number of any file ready t
Le 21/08/2014 10:17, Julien Rouhaud a écrit :
> Hello,
>
> Attached patch implements the following TODO item :
>
> Track number of WAL files ready to be archived in pg_stat_archiver
>
> However, it will track the total number of any file ready to be
> archived, not only WAL files.
>
> Please let me
Hello,
Attached patch implements the following TODO item :
Track number of WAL files ready to be archived in pg_stat_archiver
However, it will track the total number of any file ready to be
archived, not only WAL files.
Please let me know what you think about it.
Regards.
--
Julien Rouhaud
ht
15 matches
Mail list logo
