Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Hi, This is revised patch including document. I confused three identifiers to be compared, names in the catalog, those in pg_hba lines and those given from the client under connecting. This patch concerns the comparison between pg_hba and client names. Finally all the additional pg_strcasecmp() o

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Hi, At Thu, 11 Sep 2014 08:10:54 -0400, Robert Haas wrote in > On Wed, Sep 10, 2014 at 4:54 AM, Kyotaro HORIGUCHI > wrote: > > Finally I think that we need case-insensitive version of > > get_role_id and() get_database_id() to acoomplish this patch'es > > objective. (This runs full-scans on pg

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

On Wed, Sep 10, 2014 at 4:54 AM, Kyotaro HORIGUCHI wrote: > Finally I think that we need case-insensitive version of > get_role_id and() get_database_id() to acoomplish this patch'es > objective. (This runs full-scans on pg_database or pg_authid X() Any such thing is certainly grounds for rejecti

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

On Sep10, 2014, at 10:54 , Kyotaro HORIGUCHI wrote: > Under the new specifications, next_token will work as following, > > - USER : token: USER , case-insensitive > - "USeR": token: USeR , case-SENSITIVE > - "+uSeR" : token: +uSeR , case-SENSITIVE > - "+UsE"R : token: +UsEr ,

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Hmm... case-insensitive mathing could get multiple matches, which should be an error but I've forgot to do so. regards, 2014/09/10 17:54 "Kyotaro HORIGUCHI" : > And one known defect is that you will get a bit odd message if > you put an hba line having keywords quoted or prefixed with '+', > fo

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Hello, I had a closer look on this patch. Finally I think that we need case-insensitive version of get_role_id and() get_database_id() to acoomplish this patch'es objective. (This runs full-scans on pg_database or pg_authid X() And I'd like to propose to change token categorization from notation-

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Sorry for wrong suggestion. Setting in_quote is wrong there because it's before the beginning quote. Although, advancing read pointer and replacing c with the next value is still needed. regards, -- Kyotaro Horiguchi NTT Open Source Software Center 2014/09/09 20:49 "Kyotaro HORIGUCHI" : > Hello,

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Hello, I will be the reviewer of this patch. You approach that coloring tokens seems right, but you have broken the parse logic by adding your code. Other than the mistakes others pointed, I found that - non-SQL-ident like tokens are ignored by their token style, quoted or not, so the followin

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Re: Heikki Linnakangas 2014-08-21 <53f5a2d6.2050...@vmware.com> > >1) database and role names behave similar to SQL identifiers (case-sensitive > >/ case-folding). > > > >2) users and user-groups only requires special handling and behavior as > >follows > > Normal user : > > A. unquoted

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

On 07/23/2014 09:14 AM, Viswanatham kirankumar wrote: On 16 July 2014 23:12, Tom Lane wrote Christoph Berg writes: Re: Viswanatham kirankumar 2014-07-16 Attached patch is implementing following TODO item Process pg_hba.conf keywords as case-insensitive Hmm. I see a case for accepting "ALL"

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Re: Viswanatham kirankumar 2014-07-23 > 3) Host name is not a SQL object so it will be treated as case-sensitive >except for all, samehost, samenet are considered as keywords. >For these user need to use quotes to differentiate between hostname and > keywords. DNS is case-insensitive,

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

>On 16 July 2014 23:12, Tom Lane wrote >>Christoph Berg writes: >> Re: Viswanatham kirankumar 2014-07-16 >> >>> Attached patch is implementing following TODO item Process >>> pg_hba.conf keywords as case-insensitive >> Hmm. I see a case for accepting "ALL" (as in hosts.allow(5)), so +1 on >>

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

On 07/17/2014 01:41 AM, Tom Lane wrote: > Christoph Berg writes: >> Re: Viswanatham kirankumar 2014-07-16 >> >>> Attached patch is implementing following TODO item >>> Process pg_hba.conf keywords as case-insensitive > >> Hmm. I see a case for accepting "ALL" (as in hosts.allow(5)), so +1 on >>

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

On 18/07/14 04:08, Tom Lane wrote: Christoph Berg writes: One place that's been bugging me where case-insensitivity would really make sense is this: # set work_mem = '1mb'; ERROR: 22023: invalid value for parameter "work_mem": "1mb" HINT: Valid units for this parameter are "kB", "MB", and "GB

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Christoph Berg writes: > One place that's been bugging me where case-insensitivity would really > make sense is this: > # set work_mem = '1mb'; > ERROR: 22023: invalid value for parameter "work_mem": "1mb" > HINT: Valid units for this parameter are "kB", "MB", and "GB". Yeah ... there was some

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Re: Tom Lane 2014-07-16 <30956.1405532...@sss.pgh.pa.us> > Christoph Berg writes: > > Re: Viswanatham kirankumar 2014-07-16 > > > >> Attached patch is implementing following TODO item > >> Process pg_hba.conf keywords as case-insensitive > > > Hmm. I see a case for accepting "ALL" (as in hosts.

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Christoph Berg writes: > Re: Viswanatham kirankumar 2014-07-16 > >> Attached patch is implementing following TODO item >> Process pg_hba.conf keywords as case-insensitive > Hmm. I see a case for accepting "ALL" (as in hosts.allow(5)), so +1 on > that, but I don't think the other keywords like "

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Re: Viswanatham kirankumar 2014-07-16 > Attached patch is implementing following TODO item > Process pg_hba.conf keywords as case-insensitive > > * More robust pg_hba.conf parsing/error > logging Hmm. I see a case for accep

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

On Wed, Jul 16, 2014 at 6:23 PM, Viswanatham kirankumar wrote: > Attached patch is implementing following TODO item > > Process pg_hba.conf keywords as case-insensitive > > More robust pg_hba.conf parsing/error logging You should consider adding this patch to the next commit fest: https://commitfe

[HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

Attached patch is implementing following TODO item Process pg_hba.conf keywords as case-insensitive * More robust pg_hba.conf parsing/error logging Thanks & Regards, Viswanatham Kiran Kumar pg_hba.conf_keywords_as_case-inse