> Applied with really pretty minor revisions --- this was a nice clean
> patch. Changes I can recall making:
Woo-hoo, my first patch. Thanks for the cleanup.
...Robert
> * You missed one or two documentation references to DELETE privilege.
>
> * You modified the privileges test to create anoth
"Robert Haas" <[EMAIL PROTECTED]> writes:
> Updated patch attached, based on comments from Ryan Bradetich and Tom
> Lane, and sync'd to latest CVS version.
Applied with really pretty minor revisions --- this was a nice clean
patch. Changes I can recall making:
* You missed one or two documentati
Hello Robert,
On Fri, Sep 5, 2008 at 8:13 PM, Robert Haas <[EMAIL PROTECTED]> wrote:
> Updated patch attached, based on comments from Ryan Bradetich and Tom
> Lane, and sync'd to latest CVS version.
Thanks for the update. I am out of town until tomorrow evening.
I will re-review this patch when
Updated patch attached, based on comments from Ryan Bradetich and Tom
Lane, and sync'd to latest CVS version.
...Robert
On Mon, Sep 1, 2008 at 9:33 PM, Tom Lane <[EMAIL PROTECTED]> wrote:
> "Ryan Bradetich" <[EMAIL PROTECTED]> writes:
>> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <[EMAIL PROTECTED]
"Ryan Bradetich" <[EMAIL PROTECTED]> writes:
> On Mon, Sep 1, 2008 at 1:00 PM, Tom Lane <[EMAIL PROTECTED]> wrote:
>> [ something about "your patch" ]
> This is Robert Haas's patch for the September 2008 commit-fest.
> I am just offering my review.
Sorry about that, I got confused by the reply-to
I had intended to send this message to the pgsql-hackers mailing list as
well.
Thanks,
- Ryan
-- Forwarded message --
From: Ryan Bradetich <[EMAIL PROTECTED]>
Date: Mon, Sep 1, 2008 at 2:20 PM
Subject: Re: [HACKERS] [Patch Review] TRUNCATE Permission
To: Tom Lane &
"Ryan Bradetich" <[EMAIL PROTECTED]> writes:
>> I do not believe this is a huge issue since truncate is prohibited on the
>> system catalogs
>> by the truncate_check_rel().
Only when allowSystemTableMods is false. I think it would be a serious
mistake for your patch to treat the system catalogs d
Hello all,
On Sun, Aug 31, 2008 at 11:55 PM, Ryan Bradetich <[EMAIL PROTECTED]>wrote:
>
> I do not believe this is a huge issue since truncate is prohibited on the
> system catalogs
> by the truncate_check_rel().
>
> template1=# truncate pg_authid;
> ERROR: permission denied: "pg_authid" is a sy
Hello all,
Robert Haas submitted the TRUNCATE permissions patch for the September
commit fest:
http://archives.postgresql.org/message-id/[EMAIL PROTECTED]
I had some extra time tonight, so I downloaded, installed and reviewed this
patch.
Here are my findings:
1. I found the patch style to be con
