Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-06 Thread Andrew Dunstan
Simon Riggs wrote: On Fri, 2005-11-04 at 13:21 -0500, Bruce Momjian wrote: David Fetter wrote: On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote: I'm inclined to treat this as an outright bug, not just a minor performance issue, because it implies that a sufficiently l

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-06 Thread Simon Riggs
On Fri, 2005-11-04 at 13:21 -0500, Bruce Momjian wrote: > David Fetter wrote: > > On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote: > > > I'm inclined to treat this as an outright bug, not just a minor > > > performance issue, because it implies that a sufficiently long psql > > > script wo

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Dann Corbit
Subject: Re: [HACKERS] [PERFORM] insert performance for win32 > > > >> AFAICS it is appropriate to move the sigsetjmp and > > >> setup_cancel_handler calls in front of the per-line loop inside > > >> MainLoop --- can anyone see a reason not to? > > > >

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Magnus Hagander
> >> AFAICS it is appropriate to move the sigsetjmp and > >> setup_cancel_handler calls in front of the per-line loop inside > >> MainLoop --- can anyone see a reason not to? > > > hm. mainloop is re-entrant, right? That means each \i > would reset the > > handler...what is downside to keepin

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Magnus Hagander
> > I'm inclined to treat this as an outright bug, not just a minor > certainly... > > > performance issue, because it implies that a sufficiently long psql > > script would probably crash a Windows machine. > > actually, it's worse than that, it's more of a dos on the > whole system, as window

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Bruce Momjian
David Fetter wrote: > On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote: > > "Merlin Moncure" <[EMAIL PROTECTED]> writes: > > > Nailed it. > > > > > problem is in mainloop.c -> setup_cancel_handler. Apparently you > > > can have multiple handlers and windows keeps track of them all, > > >

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote: >> I'm inclined to treat this as an outright bug, not just a minor >> performance issue, because it implies that a sufficiently long psql >> script would probably crash a Windows machine. > Ouch.

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Tom Lane
"Merlin Moncure" <[EMAIL PROTECTED]> writes: >> AFAICS it is appropriate to move the sigsetjmp and >> setup_cancel_handler >> calls in front of the per-line loop inside MainLoop --- can anyone see >> a reason not to? > hm. mainloop is re-entrant, right? That means each \i would reset the > handle

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Bruce Momjian
Tom Lane wrote: > "Merlin Moncure" <[EMAIL PROTECTED]> writes: > > Nailed it. > > > problem is in mainloop.c -> setup_cancel_handler. Apparently you can > > have multiple handlers and windows keeps track of them all, even if they > > do the same thing. Keeping track of so many system handles wou

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread David Fetter
On Fri, Nov 04, 2005 at 01:01:20PM -0500, Tom Lane wrote: > "Merlin Moncure" <[EMAIL PROTECTED]> writes: > > Nailed it. > > > problem is in mainloop.c -> setup_cancel_handler. Apparently you > > can have multiple handlers and windows keeps track of them all, > > even if they do the same thing. K

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Merlin Moncure
> "Merlin Moncure" <[EMAIL PROTECTED]> writes: > > Nailed it. > > > problem is in mainloop.c -> setup_cancel_handler. Apparently you can > > have multiple handlers and windows keeps track of them all, even if they > > do the same thing. Keeping track of so many system handles would > > naturally

Re: [HACKERS] [PERFORM] insert performance for win32

2005-11-04 Thread Tom Lane
"Merlin Moncure" <[EMAIL PROTECTED]> writes: > Nailed it. > problem is in mainloop.c -> setup_cancel_handler. Apparently you can > have multiple handlers and windows keeps track of them all, even if they > do the same thing. Keeping track of so many system handles would > naturally slow the whol