daveg wrote:
> Attached is a the followon patch for pg_dumpall and docs to match pg_dump.
Thanks, committed. (The only change I did was to correct the alignment
in help output.)
--
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, C
On Thu, Jul 03, 2008 at 05:55:01AM -0700, daveg wrote:
> On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote:
> > On 5/11/08, daveg <[EMAIL PROTECTED]> wrote:
> > > Attached is a patch to add a commandline option to pg_dump to limit how
> > > long
> > > pg_dump will wait for locks during
daveg <[EMAIL PROTECTED]> writes:
> On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote:
>> - The statement_timeout is set back with "statement_timeout = default"
>> Maybe it would be better to do "= 0" here? Although such decision
>> would go outside the scope of the patch, I see no sense
On Thu, Jul 03, 2008 at 11:15:10AM +0300, Marko Kreen wrote:
> On 5/11/08, daveg <[EMAIL PROTECTED]> wrote:
> > Attached is a patch to add a commandline option to pg_dump to limit how
> > long
> > pg_dump will wait for locks during startup.
>
> My quick review:
>
> - It does not seem important
On 5/11/08, daveg <[EMAIL PROTECTED]> wrote:
> Attached is a patch to add a commandline option to pg_dump to limit how long
> pg_dump will wait for locks during startup.
My quick review:
- It does not seem important enough to waste a short option on.
Having only long option should be enough.