Re: [HACKERS] [PATCHES] Full page writes improvement, code update

2007-03-30 Thread Koichi Suzuki
Simon; Tom; Koichi is writing. Your question is how to determine WAL record generated between pg_start_backup and pg_stop_backup and here's an answer. XLogInsert( ) already has a logic to determine if inserting WAL record is between pg_start_backup and pg_stop_backup. Currently it is used to

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-08 Thread Koichi Suzuki
Full_page_compress is not intended to use with PITR slave, but for the case to keep both online backup and archive log for archive recovery, which is very popular PostgreSQL operation now. I've just posted my evaluation for the patch as a reply for another thread of the same proposal (sorry, I cre

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Koichi Suzuki
Tom Lane wrote: > Koichi Suzuki <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Doesn't this break crash recovery on PITR slaves? > >> Compressed archive log contains the same data as full_page_writes off >> case. So the influence to PITR slaves is the same as full_page_writes off. > > Right

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Tom Lane
Koichi Suzuki <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Doesn't this break crash recovery on PITR slaves? > Compressed archive log contains the same data as full_page_writes off > case. So the influence to PITR slaves is the same as full_page_writes off. Right. So what is the use-case f

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Koichi Suzuki
Tom Lane wrote: > Koichi Suzuki <[EMAIL PROTECTED]> writes: >> Here's an idea and a patch for full page writes improvement. > >> Idea: >> (1) keep full page writes for ordinary WAL, make them available during >> the crash recovery, -> recovery from inconsistent pages which can be >> made at the cr

Re: [HACKERS] [PATCHES] Full page writes improvement

2007-02-01 Thread Tom Lane
Koichi Suzuki <[EMAIL PROTECTED]> writes: > Here's an idea and a patch for full page writes improvement. > Idea: > (1) keep full page writes for ordinary WAL, make them available during > the crash recovery, -> recovery from inconsistent pages which can be > made at the crash, > (2) Remove them fr