Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-12-06 Thread Andres Freund
Hi, I tried to address most (all?) your comments in the version from http://archives.postgresql.org/message-id/20121204175212.GB12055%40awork2.anarazel.de . On 2012-11-15 11:31:55 -0500, Peter Eisentraut wrote: > > +xlogdump: $(OBJS) $(shell find ../../backend ../../timezone -name > > objfiles.t

Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-21 Thread Andres Freund
On 2012-11-21 14:57:14 -0800, Jeff Janes wrote: > On Thu, Nov 15, 2012 at 9:13 AM, Andres Freund wrote: > > On 2012-11-15 09:06:23 -0800, Jeff Janes wrote: > >> On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund > >> wrote: > >> > --- > >> > src/bin/Makefile| 2 +- > >> > src/bin/xlog

Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-21 Thread Jeff Janes
On Thu, Nov 15, 2012 at 9:13 AM, Andres Freund wrote: > On 2012-11-15 09:06:23 -0800, Jeff Janes wrote: >> On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund >> wrote: >> > --- >> > src/bin/Makefile| 2 +- >> > src/bin/xlogdump/Makefile | 25 +++ >> > src/bin/xlogdump/xlogdump.c |

Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-15 Thread Andres Freund
On 2012-11-15 09:06:23 -0800, Jeff Janes wrote: > On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund wrote: > > --- > > src/bin/Makefile| 2 +- > > src/bin/xlogdump/Makefile | 25 +++ > > src/bin/xlogdump/xlogdump.c | 468 > > > > 3 files

Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-15 Thread Jeff Janes
On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund wrote: > --- > src/bin/Makefile| 2 +- > src/bin/xlogdump/Makefile | 25 +++ > src/bin/xlogdump/xlogdump.c | 468 > > 3 files changed, 494 insertions(+), 1 deletion(-) > create mode 1006

Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-15 Thread Andres Freund
On 2012-11-15 11:31:55 -0500, Peter Eisentraut wrote: > On 11/14/12 8:17 PM, Andres Freund wrote: > > diff --git a/src/bin/Makefile b/src/bin/Makefile > > index b4dfdba..9992f7a 100644 > > --- a/src/bin/Makefile > > +++ b/src/bin/Makefile > > @@ -14,7 +14,7 @@ top_builddir = ../.. > > include $(to

Re: [HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-15 Thread Peter Eisentraut
On 11/14/12 8:17 PM, Andres Freund wrote: > diff --git a/src/bin/Makefile b/src/bin/Makefile > index b4dfdba..9992f7a 100644 > --- a/src/bin/Makefile > +++ b/src/bin/Makefile > @@ -14,7 +14,7 @@ top_builddir = ../.. > include $(top_builddir)/src/Makefile.global > > SUBDIRS = initdb pg_ctl pg_du

[HACKERS] [PATCH 03/14] Add simple xlogdump tool

2012-11-14 Thread Andres Freund
--- src/bin/Makefile| 2 +- src/bin/xlogdump/Makefile | 25 +++ src/bin/xlogdump/xlogdump.c | 468 3 files changed, 494 insertions(+), 1 deletion(-) create mode 100644 src/bin/xlogdump/Makefile create mode 100644 src/bin/xlogdump/xlog