Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-07-02 Thread Andres Freund
On Monday, July 02, 2012 03:51:08 PM Robert Haas wrote: > On Wed, Jun 27, 2012 at 6:33 AM, Andres Freund wrote: > >> Will do so. Not sure if I can finish it today though, I am in the midst > >> of redoing the ilist and xlogreader patches. I guess tomorrow will > >> suffice otherwise... > > > > O

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-07-02 Thread Robert Haas
On Wed, Jun 27, 2012 at 6:33 AM, Andres Freund wrote: >> Will do so. Not sure if I can finish it today though, I am in the midst of >> redoing the ilist and xlogreader patches. I guess tomorrow will suffice >> otherwise... > Ok, attached are two patches: > The first is the rebased version of the o

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-27 Thread Andres Freund
On Tuesday, June 26, 2012 04:06:08 PM Andres Freund wrote: > On Tuesday, June 26, 2012 04:01:26 PM Robert Haas wrote: > > On Fri, Jun 22, 2012 at 12:35 PM, Andres Freund > > wrote: > > >> Can you elaborate on that a bit? What scenarios did you play around > > >> with, and what does "win" mean in

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-26 Thread Andres Freund
On Tuesday, June 26, 2012 04:01:26 PM Robert Haas wrote: > On Fri, Jun 22, 2012 at 12:35 PM, Andres Freund wrote: > >> Can you elaborate on that a bit? What scenarios did you play around > >> with, and what does "win" mean in this context? > > > > I had two machines connected locally and setup

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-26 Thread Robert Haas
On Fri, Jun 22, 2012 at 12:35 PM, Andres Freund wrote: >> Can you elaborate on that a bit?  What scenarios did you play around >> with, and what does "win" mean in this context? > I had two machines connected locally and setup HS and my prototype between > them (not at once obviously). > The patch

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-22 Thread Andres Freund
On Friday, June 22, 2012 04:59:45 PM Robert Haas wrote: > On Fri, Jun 22, 2012 at 10:45 AM, Andres Freund wrote: > >> > the likelihood of that as you know. > >> > >> Hmm, well, I guess. I'm still not sure I really understand what > >> benefit we're getting out of this. If we lose a few WAL rec

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-22 Thread Robert Haas
On Fri, Jun 22, 2012 at 10:45 AM, Andres Freund wrote: >> > the likelihood of that as you know. >> Hmm, well, I guess.  I'm still not sure I really understand what >> benefit we're getting out of this.  If we lose a few WAL records for >> an uncommitted transaction, who cares?  That transaction is

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-22 Thread Andres Freund
On Friday, June 22, 2012 04:34:33 PM Robert Haas wrote: > On Fri, Jun 22, 2012 at 10:19 AM, Andres Freund wrote: > > On Friday, June 22, 2012 04:09:59 PM Robert Haas wrote: > >> >> I am not convinced that it's a good idea to wake up every walsender > >> >> every time we do XLogInsert(). XLogInse

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-22 Thread Robert Haas
On Fri, Jun 22, 2012 at 10:19 AM, Andres Freund wrote: > On Friday, June 22, 2012 04:09:59 PM Robert Haas wrote: >> >> I am not convinced that it's a good idea to wake up every walsender >> >> every time we do XLogInsert().  XLogInsert() is a super-hot code path, >> >> and adding more overhead the

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-22 Thread Andres Freund
On Friday, June 22, 2012 04:09:59 PM Robert Haas wrote: > >> I am not convinced that it's a good idea to wake up every walsender > >> every time we do XLogInsert(). XLogInsert() is a super-hot code path, > >> and adding more overhead there doesn't seem warranted. We need to > >> replicate commit,

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-22 Thread Robert Haas
>> I am not convinced that it's a good idea to wake up every walsender >> every time we do XLogInsert().  XLogInsert() is a super-hot code path, >> and adding more overhead there doesn't seem warranted.  We need to >> replicate commit, commit prepared, etc. quickly, by why do we need to >> worry ab

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-19 Thread Andres Freund
On Tuesday, June 19, 2012 09:55:30 PM Robert Haas wrote: > On Wed, Jun 13, 2012 at 7:28 AM, Andres Freund wrote: > > From: Andres Freund > > > > The previous coding could miss xlog writeouts at several places. E.g. > > when wal was written out by the background writer or even after a commit > >

Re: [HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-19 Thread Robert Haas
On Wed, Jun 13, 2012 at 7:28 AM, Andres Freund wrote: > From: Andres Freund > > The previous coding could miss xlog writeouts at several places. E.g. when wal > was written out by the background writer or even after a commit if > synchronous_commit=off. > This could lead to delays in sending data

[HACKERS] [PATCH 01/16] Overhaul walsender wakeup handling

2012-06-13 Thread Andres Freund
From: Andres Freund The previous coding could miss xlog writeouts at several places. E.g. when wal was written out by the background writer or even after a commit if synchronous_commit=off. This could lead to delays in sending data to the standby of up to 7 seconds. To fix this move the responsi