Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-02-09 Thread Magnus Hagander
On Mon, Feb 3, 2014 at 4:14 AM, Sawada Masahiko wrote: > On Sat, Feb 1, 2014 at 8:29 PM, Oskari Saarenmaa wrote: > > 31.01.2014 10:59, Sawada Masahiko kirjoitti: > > > > I think the idea in the new progress_report() call (with force == true) > is > > to make sure that there is at least one progre

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-02-02 Thread Sawada Masahiko
On Sat, Feb 1, 2014 at 8:29 PM, Oskari Saarenmaa wrote: > 31.01.2014 10:59, Sawada Masahiko kirjoitti: > > I think the idea in the new progress_report() call (with force == true) is > to make sure that there is at least one progress_report call that actually > writes the progress report. Otherwis

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-02-01 Thread Oskari Saarenmaa
31.01.2014 10:59, Sawada Masahiko kirjoitti: On Tue, Jan 21, 2014 at 7:17 AM, Oskari Saarenmaa wrote: 18.11.2013 07:53, Sawada Masahiko kirjoitti: On 13 Nov 2013, at 20:51, Mika Eloranta wrote: Prevent excessive progress reporting that can grow to gigabytes of output with large databases.

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-31 Thread Sawada Masahiko
On Tue, Jan 21, 2014 at 7:17 AM, Oskari Saarenmaa wrote: > 18.11.2013 07:53, Sawada Masahiko kirjoitti: >>> >>> On 13 Nov 2013, at 20:51, Mika Eloranta wrote: Prevent excessive progress reporting that can grow to gigabytes of output with large databases. >> >> >> I got error with f

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-20 Thread Oskari Saarenmaa
18.11.2013 07:53, Sawada Masahiko kirjoitti: On 13 Nov 2013, at 20:51, Mika Eloranta wrote: Prevent excessive progress reporting that can grow to gigabytes of output with large databases. I got error with following scenario. $ initdb -D data -E UTF8 --no-locale /* setting the replication par

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-11 Thread Magnus Hagander
On Fri, Jan 10, 2014 at 3:56 AM, Mika Eloranta wrote: > On Thu, Jan 9, 2014, at 20:05, Magnus Hagander wrote: > > On Thu, Nov 14, 2013 at 10:27 AM, Mika Eloranta wrote: > >> On 13 Nov 2013, at 20:51, Mika Eloranta wrote: > >> > >> > >> > > Prevent excessive progress reporting that can grow to g

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-10 Thread Mika Eloranta
On Thu, Jan 9, 2014, at 20:05, Magnus Hagander wrote: > On Thu, Nov 14, 2013 at 10:27 AM, Mika Eloranta wrote: >> On 13 Nov 2013, at 20:51, Mika Eloranta wrote: >> >> >> > Prevent excessive progress reporting that can grow to gigabytes >> > of output with large databases. >> >> >> Same patc

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-09 Thread Mika Eloranta
On Thu, Jan 9, 2014, at 20:05, Magnus Hagander wrote: > On Thu, Nov 14, 2013 at 10:27 AM, Mika Eloranta wrote: >> On 13 Nov 2013, at 20:51, Mika Eloranta wrote: >> >> >> > Prevent excessive progress reporting that can grow to gigabytes >> > of output with large databases. >> >> >> Same patc

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-01-09 Thread Magnus Hagander
On Thu, Nov 14, 2013 at 10:27 AM, Mika Eloranta wrote: > On 13 Nov 2013, at 20:51, Mika Eloranta wrote: > > > Prevent excessive progress reporting that can grow to gigabytes > > of output with large databases. > > Same patch as an attachment. > Would it not make more sense to instead store the

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2013-11-17 Thread Sawada Masahiko
On Thu, Nov 14, 2013 at 6:27 PM, Mika Eloranta wrote: > On 13 Nov 2013, at 20:51, Mika Eloranta wrote: > >> Prevent excessive progress reporting that can grow to gigabytes >> of output with large databases. > > Same patch as an attachment. > > -- > Mika Eloranta > Ohmu Ltd. http://www.ohmu.fi/ >

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2013-11-14 Thread Marko Tiikkaja
On 11/14/13 10:27 AM, Mika Eloranta wrote: On 13 Nov 2013, at 20:51, Mika Eloranta wrote: Prevent excessive progress reporting that can grow to gigabytes of output with large databases. Same patch as an attachment. I can't comment on the usefulness of this patch, but the first hunk in pro

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2013-11-14 Thread Mika Eloranta
On 13 Nov 2013, at 20:51, Mika Eloranta wrote: > Prevent excessive progress reporting that can grow to gigabytes > of output with large databases. Same patch as an attachment. -- Mika Eloranta Ohmu Ltd. http://www.ohmu.fi/ 0001-pg_basebackup-progress-report-max-once-per-second.patch Descri

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2013-11-13 Thread Michael Paquier
Iy On Thu, Nov 14, 2013 at 3:51 AM, Mika Eloranta wrote: > Prevent excessive progress reporting that can grow to gigabytes > of output with large databases. It might be interesting to add this patch to the next commit fest where you could get a formal review: https://commitfest.postgresql.org/act

[HACKERS] [PATCH] pg_basebackup: progress report max once per second

2013-11-13 Thread Mika Eloranta
Prevent excessive progress reporting that can grow to gigabytes of output with large databases. --- src/bin/pg_basebackup/pg_basebackup.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_bas