Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-12-12 Thread Michael Paquier
On Fri, Dec 13, 2013 at 12:03 PM, Peter Eisentraut wrote: > On Wed, 2013-11-20 at 01:08 +0200, Oskari Saarenmaa wrote: >> Agreed. Attached an updated patch, or you can grab it from >> https://github.com/saaros/postgres/compare/extra-version > > Committed. Thanks. -- Michael -- Sent via pgsql-

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-12-12 Thread Peter Eisentraut
On Wed, 2013-11-20 at 01:08 +0200, Oskari Saarenmaa wrote: > Agreed. Attached an updated patch, or you can grab it from > https://github.com/saaros/postgres/compare/extra-version Committed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscrip

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-23 Thread Peter Eisentraut
On Wed, 2013-11-20 at 22:41 +0900, Michael Paquier wrote: > Here are a couple of comments about the patch: > 1) I think that you should regenerate ./configure as well with this > patch to include all the changes together (someone correct me if I am > wrong here!) Doesn't matter either way. > 2) T

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-20 Thread Michael Paquier
On Wed, Nov 20, 2013 at 8:08 AM, Oskari Saarenmaa wrote: > > On Mon, Nov 18, 2013 at 08:48:13PM -0500, Peter Eisentraut wrote: > > On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote: > > > This can be used to tag custom built packages with an extra version string > > > such as the git descr

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-19 Thread Oskari Saarenmaa
On Mon, Nov 18, 2013 at 08:48:13PM -0500, Peter Eisentraut wrote: > On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote: > > This can be used to tag custom built packages with an extra version string > > such as the git describe id or distribution package release version. > > I think this is

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-18 Thread Michael Paquier
On Tue, Nov 19, 2013 at 10:48 AM, Peter Eisentraut wrote: > I think this is a reasonable feature, and the implementation is OK, but > I don't see why the format of the extra version information needs to be > exactly > > PG_VERSION="$PACKAGE_VERSION ($withval)" > > I'd imagine, for example, tha

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-18 Thread Peter Eisentraut
On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote: > This can be used to tag custom built packages with an extra version string > such as the git describe id or distribution package release version. I think this is a reasonable feature, and the implementation is OK, but I don't see why the

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-05 Thread Michael Paquier
On Tue, Nov 5, 2013 at 4:29 PM, Oskari Saarenmaa wrote: > This can be used to tag custom built packages with an extra version string > such as the git describe id or distribution package release version. Could you attach a proper patch to your email and register it to the next commit fest? Typical

[HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

2013-11-05 Thread Oskari Saarenmaa
This can be used to tag custom built packages with an extra version string such as the git describe id or distribution package release version. Based on pgsql-hackers discussion: http://www.postgresql.org/message-id/20131105102226.ga26...@saarenmaa.fi Signed-off-by: Oskari Saarenmaa --- configu