Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-19 Thread Robert Haas
On Wed, Nov 18, 2015 at 12:32 AM, Haribabu Kommi wrote: > On Wed, Nov 18, 2015 at 6:02 AM, Robert Haas wrote: >> On Mon, Nov 16, 2015 at 4:27 AM, Marti Raudsepp wrote: >>> Thank you so much for the review and patch update. I should have done that >>> myself, but I've been really busy for the las

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-17 Thread Haribabu Kommi
On Wed, Nov 18, 2015 at 6:02 AM, Robert Haas wrote: > On Mon, Nov 16, 2015 at 4:27 AM, Marti Raudsepp wrote: >> Thank you so much for the review and patch update. I should have done that >> myself, but I've been really busy for the last few weeks. :( > > Maybe I'm having an attack of the stupids

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-17 Thread Robert Haas
On Mon, Nov 16, 2015 at 4:27 AM, Marti Raudsepp wrote: > Thank you so much for the review and patch update. I should have done that > myself, but I've been really busy for the last few weeks. :( Maybe I'm having an attack of the stupids today, but it looks to me like the changes to pg_constraint.

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-16 Thread Marti Raudsepp
Hi Haribabu Kommi Thank you so much for the review and patch update. I should have done that myself, but I've been really busy for the last few weeks. :( Regards, Marti On Mon, Nov 16, 2015 at 4:46 AM, Haribabu Kommi wrote: > On Thu, Nov 5, 2015 at 10:20 PM, Haribabu Kommi > wrote: > > On Tue

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-15 Thread Haribabu Kommi
On Thu, Nov 5, 2015 at 10:20 PM, Haribabu Kommi wrote: > On Tue, Sep 29, 2015 at 12:17 AM, Marti Raudsepp wrote: >> Hi list >> >> The attached patch changes the behavior of multiple ALTER x SET SCHEMA >> commands, to skip, rather than fail, when the old and new schema is >> the same. >> >> The ad

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-05 Thread David G. Johnston
On Thu, Nov 5, 2015 at 2:15 PM, Robert Haas wrote: > On Thu, Nov 5, 2015 at 6:20 AM, Haribabu Kommi > wrote: > > I went through the patch, following are my observations, > > > > Patch applied with hunks and compiled with out warnings. > > Basic tests are passed. > > I'm interested in hearing opi

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-05 Thread Alvaro Herrera
David G. Johnston wrote: > On Thu, Nov 5, 2015 at 2:15 PM, Robert Haas wrote: > > I'm interested in hearing opinions from multiple people about the > > following two questions: > > > > 1. Is the new behavior better than the old behavior? > > 2. Will breaking backward compatibility make too many p

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-05 Thread Robert Haas
On Thu, Nov 5, 2015 at 6:20 AM, Haribabu Kommi wrote: > I went through the patch, following are my observations, > > Patch applied with hunks and compiled with out warnings. > Basic tests are passed. I'm interested in hearing opinions from multiple people about the following two questions: 1. Is

Re: [HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-11-05 Thread Haribabu Kommi
On Tue, Sep 29, 2015 at 12:17 AM, Marti Raudsepp wrote: > Hi list > > The attached patch changes the behavior of multiple ALTER x SET SCHEMA > commands, to skip, rather than fail, when the old and new schema is > the same. > > The advantage is that it's now easier to write DDL scripts that are >

[HACKERS] [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change

2015-09-28 Thread Marti Raudsepp
Hi list The attached patch changes the behavior of multiple ALTER x SET SCHEMA commands, to skip, rather than fail, when the old and new schema is the same. The advantage is that it's now easier to write DDL scripts that are indempotent. This already matches the behavior of ALTER EXTENSION SET S