Re: [HACKERS] [PATCH] Send catalog_xmin separately in hot standby feedback

2016-11-10 Thread Craig Ringer
On 25 October 2016 at 00:19, Petr Jelinek wrote: >> Now formatted a series: >> >> 1. Send catalog_xmin in hot standby feedback protocol > >> + xmin_epoch = nextEpoch; >> if (nextXid < xmin) >> - nextEpoch--; >> + xmin_epoch --; >> + catalog_xmin_epoch =

Re: [HACKERS] [PATCH] Send catalog_xmin separately in hot standby feedback

2016-10-24 Thread Petr Jelinek
Hi Craig, On 05/09/16 11:28, Craig Ringer wrote: > On 5 September 2016 at 14:44, Craig Ringer wrote: >> On 5 September 2016 at 12:40, Craig Ringer wrote: >>> Hi all >>> >>> Currently hot standby feedback sends GetOldestXmin()'s result to the >>> upstream as the required xmin. GetOldestXmin() ret

Re: [HACKERS] [PATCH] Send catalog_xmin separately in hot standby feedback

2016-09-05 Thread Craig Ringer
On 5 September 2016 at 14:44, Craig Ringer wrote: > On 5 September 2016 at 12:40, Craig Ringer wrote: >> Hi all >> >> Currently hot standby feedback sends GetOldestXmin()'s result to the >> upstream as the required xmin. GetOldestXmin() returns a slot's >> catalog_xmin if that's the lowest xmin o

Re: [HACKERS] [PATCH] Send catalog_xmin separately in hot standby feedback

2016-09-04 Thread Craig Ringer
On 5 September 2016 at 12:40, Craig Ringer wrote: > Hi all > > Currently hot standby feedback sends GetOldestXmin()'s result to the > upstream as the required xmin. GetOldestXmin() returns a slot's > catalog_xmin if that's the lowest xmin on the system. Note that this patch changes the API to Ge

[HACKERS] [PATCH] Send catalog_xmin separately in hot standby feedback

2016-09-04 Thread Craig Ringer
Hi all Currently hot standby feedback sends GetOldestXmin()'s result to the upstream as the required xmin. GetOldestXmin() returns a slot's catalog_xmin if that's the lowest xmin on the system. That's fine so long as we don't do logical decoding on standbys, but if we start allowing logical slots