On Wed, Oct 9, 2013 at 10:44 AM, Peter Eisentraut wrote:
> On Thu, 2013-10-03 at 17:50 +0530, Jeevan Chalke wrote:
> > Will you please attach new patch with above block removed ? Then I
> > will quickly check that new patch and mark as "Ready For Committer".
> >
> Here you go.
>
>
Thanks Peter. P
On Thu, 2013-10-03 at 17:50 +0530, Jeevan Chalke wrote:
> Will you please attach new patch with above block removed ? Then I
> will quickly check that new patch and mark as "Ready For Committer".
>
Here you go.
From ba421c778cc3f7c32886ac038389cfbad3c0df67 Mon Sep 17 00:00:00 2001
From: Peter Eis
On Wed, Oct 2, 2013 at 6:12 AM, Peter Eisentraut wrote:
> On Wed, 2013-09-25 at 14:26 +0530, Jeevan Chalke wrote:
> > So no issues from my side.
> >
> > However, do we still need this in close_pl() ?
> >
> > #ifdef NOT_USED
> > if (FPeq(line->A, -1.0) && FPzero(line->B))
> > {
On Wed, 2013-09-25 at 14:26 +0530, Jeevan Chalke wrote:
> So no issues from my side.
>
> However, do we still need this in close_pl() ?
>
> #ifdef NOT_USED
> if (FPeq(line->A, -1.0) && FPzero(line->B))
> {/* vertical */
> }
> #endif
No, that can be removed
Hi,
I had a look over this patch and here are my review points:
1. Patch applies cleanly.
2. make, make install and make check is good.
3. I did lot of random testing and didn't find any issue.
4. Test coverage is very well. It has all scenarios and all operators are
tested with line. That's real
David Fetter escribió:
> Should the things you tried and others be in the regression tests? If
> so, should we start with whatever had been in the regression tests
> when the line type was dropped?
Actually, the patch does include a regression test for the revived type
(and it passes). I don't
On Mon, Sep 16, 2013 at 07:04:32PM -0300, Alvaro Herrera wrote:
> Peter Eisentraut escribió:
> > Here is a new patch for the line type, with a new input/output format
> > {A,B,C}, as discussed in this thread.
>
> I gave this a quick look. The new input/output format appears to work
> well. The i
Peter Eisentraut escribió:
> Here is a new patch for the line type, with a new input/output format
> {A,B,C}, as discussed in this thread.
I gave this a quick look. The new input/output format appears to work
well. The input format using two points still works, which is nice.
Regression tests pa
Here is a new patch for the line type, with a new input/output format
{A,B,C}, as discussed in this thread.
>From 837fcf5d9b1ee8e589ef4b19f7d6e575229ca758 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Sun, 15 Sep 2013 00:02:06 -0400
Subject: [PATCH] Revive line type
Change the input/out
On 6/26/13 9:34 PM, Peter Eisentraut wrote:
Still wondering whether to use a A,B,C-based output
format per Tom's comment.
Wouldn't it also be helpful to remove "The points used in the output are
not necessarily the points used on input" by making that not true?
There are three obvious ways y
On Sun, 2013-06-23 at 12:24 +0800, rui hua wrote:
> Regression tests are all succeed, but several problems have be found while
> ding some simple test. The updated document said that the points used in
> the output are not necessarily the points used on input. I understand that
> as long as they a
Hi,
Test results are as follows:
Contents & Purpose
This patch is for finishing the line type and related functions that not
done yet but listed in catalogs and documentation. There are no other new
features added in this patch.
The regression test cases which included in this patch, Documentat
Peter Eisentraut writes:
> Complete the implementations of line_in, line_out, line_recv,
> line_send. Remove comments and error messages about the line type not
> being implemented. Add regression tests for existing line operators
> and functions.
> ---
> This just revives existing functionality
Complete the implementations of line_in, line_out, line_recv,
line_send. Remove comments and error messages about the line type not
being implemented. Add regression tests for existing line operators
and functions.
---
This just revives existing functionality, doesn't add anything new.
One thing
14 matches
Mail list logo
