On 12/14/16 6:10 PM, Vladimir Rusinov wrote:
> Either way, I've attached another version of my patch - this time it
> avoids touching example psql output. Baby steps.
> I'll let you decide on the way forward. I'm just happy to send some patches.
committed
--
Peter Eisentraut http://
On 12/14/16 5:12 PM, Stephen Frost wrote:
> For my 2c, at least, because we're going to be constantly fighting with
> the trailing whitespace in those examples. If you forget to s/ the docs aren't going to build and it's going to be extremely obvious
> that you need to do something. Not that I'm
On Wed, Dec 14, 2016 at 9:37 PM, Stephen Frost wrote:
> * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> > On 12/14/16 12:03 PM, Stephen Frost wrote:
> > > If we do want to change that, perhaps we should also change psql to not
> > > output the trailing whitespace in the first place
Alvaro,
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> Tom Lane wrote:
>
> > Thinking about this, I'm wondering what is the connection between
> > what psql does and what should be in the SGML (or XML) docs, anyway.
> > Nobody says boo when we have to do s/ > to put it in the docs; why is s
Tom Lane wrote:
> Thinking about this, I'm wondering what is the connection between
> what psql does and what should be in the SGML (or XML) docs, anyway.
> Nobody says boo when we have to do s/ to put it in the docs; why is stripping trailing whitespace a bigger
> issue?
Why do we need to put re
Tom,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> The real problem here, IMO, is the break in expected regression outputs.
> The previous thread mainly discussed that in terms of its impact on
> third-party tests using pg_regress, but for our own purposes it would be
> just as nasty to need to adjust
On 12/14/16 4:51 PM, Tom Lane wrote:
> Thinking about this, I'm wondering what is the connection between
> what psql does and what should be in the SGML (or XML) docs, anyway.
> Nobody says boo when we have to do s/ to put it in the docs; why is stripping trailing whitespace a bigger
> issue?
Ther
Stephen Frost writes:
> * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
>> Previous discussion:
>> https://www.postgresql.org/message-id/flat/1285093687.5468.18.camel%40vanquo.pezone.net
> Thanks for that, but, frankly, it seems like most were in agreement that
> we should go ahead a
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 12/14/16 12:03 PM, Stephen Frost wrote:
> > If we do want to change that, perhaps we should also change psql to not
> > output the trailing whitespace in the first place..?
>
> Previous discussion:
> https://www.postgresql.org/messa
On 12/14/16 12:03 PM, Stephen Frost wrote:
> If we do want to change that, perhaps we should also change psql to not
> output the trailing whitespace in the first place..?
Previous discussion:
https://www.postgresql.org/message-id/flat/1285093687.5468.18.camel%40vanquo.pezone.net
--
Peter Eisent
* Vladimir Rusinov (vrusi...@google.com) wrote:
> I'm not sure if it makes sense to merge just these, as it will not help
> people with whitespace-eating editors.
I think we've established that it's going to be quite a while before we
will reach a point where whitespace-eating editors aren't a pro
On Wed, Dec 14, 2016 at 5:41 PM, Stephen Frost wrote:
> > They are considered bad practice in many style guides and many editors
> > configured to stip them on every save.
> >
> > Such editors will produce spurious diffs when editing the documentation.
> >
> > Therefore, I propose this patch.
>
>
* Vladimir Rusinov (vrusi...@google.com) wrote:
> They are considered bad practice in many style guides and many editors
> configured to stip them on every save.
>
> Such editors will produce spurious diffs when editing the documentation.
>
> Therefore, I propose this patch.
As mentioned down-th
On Wed, Dec 14, 2016 at 5:14 PM, Tom Lane wrote:
> Stephen Frost writes:
> > If we do want to change that, perhaps we should also change psql to not
> > output the trailing whitespace in the first place..?
>
> Yeah, maybe. I seem to recall having looked at that a long time ago
> and deciding th
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost writes:
> > If we do want to change that, perhaps we should also change psql to not
> > output the trailing whitespace in the first place..?
>
> Yeah, maybe. I seem to recall having looked at that a long time ago
> and deciding that it wasn'
On Wed, Dec 14, 2016 at 4:50 PM, Tom Lane wrote:
> Vladimir Rusinov writes:
> > Therefore, I propose this patch.
>
> Right now is a really bad time to do that; what it will mostly accomplish
> is to break back-patching of doc fixes for little benefit.
>
ack. As I said, it's a proposal and I'm n
Stephen Frost writes:
> If we do want to change that, perhaps we should also change psql to not
> output the trailing whitespace in the first place..?
Yeah, maybe. I seem to recall having looked at that a long time ago
and deciding that it wasn't worth the trouble, but the code involved
has prob
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Vladimir Rusinov writes:
> > Therefore, I propose this patch.
>
> Right now is a really bad time to do that; what it will mostly accomplish
> is to break back-patching of doc fixes for little benefit.
>
> There is work afoot to convert the documentation t
Vladimir Rusinov writes:
> Therefore, I propose this patch.
Right now is a really bad time to do that; what it will mostly accomplish
is to break back-patching of doc fixes for little benefit.
There is work afoot to convert the documentation to xml. If that
succeeds, it'd make sense to strip tr
They are considered bad practice in many style guides and many editors
configured to stip them on every save.
Such editors will produce spurious diffs when editing the documentation.
Therefore, I propose this patch.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon Hou
20 matches
Mail list logo
