Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2015-03-21 Thread Bruce Momjian
On Thu, Mar 19, 2015 at 12:16:07PM -0400, Bruce Momjian wrote: > On Mon, Oct 13, 2014 at 11:35:18AM -0400, Bruce Momjian wrote: > > On Mon, Oct 13, 2014 at 05:21:32PM +0200, Andres Freund wrote: > > > > If we have it, we should improve it, or remove it. We might want to use > > > > this code for s

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2015-03-19 Thread Robert Haas
On Thu, Mar 19, 2015 at 12:16 PM, Bruce Momjian wrote: > On Mon, Oct 13, 2014 at 11:35:18AM -0400, Bruce Momjian wrote: >> On Mon, Oct 13, 2014 at 05:21:32PM +0200, Andres Freund wrote: >> > > If we have it, we should improve it, or remove it. We might want to use >> > > this code for something e

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2015-03-19 Thread Bruce Momjian
On Mon, Oct 13, 2014 at 11:35:18AM -0400, Bruce Momjian wrote: > On Mon, Oct 13, 2014 at 05:21:32PM +0200, Andres Freund wrote: > > > If we have it, we should improve it, or remove it. We might want to use > > > this code for something else in the future, so it should be improved > > > where feasi

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Sean Chittenden
> Really? Why? Because it was found to be lighter weight. See ยง5 (bottom of ppg 8). https://kib.kiev.ua/kib/pgsql_perf.pdf > According to the notes in our code, named POSIX semaphores > are the least attractive of the three Unixoid semaphore APIs we support, > because they require eating a fil

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Bruce Momjian
On Mon, Oct 13, 2014 at 05:21:32PM +0200, Andres Freund wrote: > > If we have it, we should improve it, or remove it. We might want to use > > this code for something else in the future, so it should be improved > > where feasible. > > Meh. We don't put in effort into code that doesn't matter jus

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Andres Freund
On 2014-10-13 11:18:26 -0400, Bruce Momjian wrote: > On Mon, Oct 13, 2014 at 04:19:39PM +0200, Andres Freund wrote: > > On 2014-10-13 10:15:29 -0400, Robert Haas wrote: > > > On Sun, Oct 12, 2014 at 5:36 AM, Andres Freund > > > wrote: > > > > IIRC, as pointed out above, it's primarily based on a

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Bruce Momjian
On Mon, Oct 13, 2014 at 04:19:39PM +0200, Andres Freund wrote: > On 2014-10-13 10:15:29 -0400, Robert Haas wrote: > > On Sun, Oct 12, 2014 at 5:36 AM, Andres Freund > > wrote: > > > IIRC, as pointed out above, it's primarily based on a misunderstanding > > > about when mmap is used for in dsm. I.

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Tom Lane
Sean Chittenden writes: > In the same breath, it would also be nice if the following were committed: > [ use named POSIX semaphores on FreeBSD ] Really? Why? According to the notes in our code, named POSIX semaphores are the least attractive of the three Unixoid semaphore APIs we support, becau

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Andres Freund
On 2014-10-13 07:49:44 -0700, Sean Chittenden wrote: > >> Perhaps, but I still see no reason not to apply it. It may not help > >> many people, but it won't hurt anything, either. So why not? > > > > More complicated, less tested code. For no practial benefit, it'll still > > be slower than posi

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Sean Chittenden
>> Perhaps, but I still see no reason not to apply it. It may not help >> many people, but it won't hurt anything, either. So why not? > > More complicated, less tested code. For no practial benefit, it'll still > be slower than posix shm if there's any memmory pressure. But if you > want to app

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Andres Freund
On 2014-10-13 10:15:29 -0400, Robert Haas wrote: > On Sun, Oct 12, 2014 at 5:36 AM, Andres Freund wrote: > > IIRC, as pointed out above, it's primarily based on a misunderstanding > > about when mmap is used for in dsm. I.e. that it's essentially just a > > fallback/toy implementation and that pos

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-13 Thread Robert Haas
On Sun, Oct 12, 2014 at 5:36 AM, Andres Freund wrote: > On 2014-10-11 20:33:57 -0400, Bruce Momjian wrote: >> On Tue, Aug 12, 2014 at 07:08:06PM -0400, Robert Haas wrote: >> > On Tue, Aug 12, 2014 at 12:59 PM, Andres Freund >> > wrote: >> > > On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote:

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-12 Thread Andres Freund
On 2014-10-11 20:33:57 -0400, Bruce Momjian wrote: > On Tue, Aug 12, 2014 at 07:08:06PM -0400, Robert Haas wrote: > > On Tue, Aug 12, 2014 at 12:59 PM, Andres Freund > > wrote: > > > On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote: > > >> One of the patches that I've been sitting on and am de

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-11 Thread Bruce Momjian
On Tue, Aug 12, 2014 at 07:08:06PM -0400, Robert Haas wrote: > On Tue, Aug 12, 2014 at 12:59 PM, Andres Freund > wrote: > > On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote: > >> One of the patches that I've been sitting on and am derelict in punting > >> upstream is the attached mmap(2) flags

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-08-12 Thread Robert Haas
On Tue, Aug 12, 2014 at 12:59 PM, Andres Freund wrote: > On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote: >> One of the patches that I've been sitting on and am derelict in punting >> upstream is the attached mmap(2) flags patch for the BSDs. Is there any >> chance this can be squeezed in to t

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-08-12 Thread Andres Freund
On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote: > One of the patches that I've been sitting on and am derelict in punting > upstream is the attached mmap(2) flags patch for the BSDs. Is there any > chance this can be squeezed in to the PostreSQL 9.4 release? > > The patch is trivial in size a

[HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-08-12 Thread Sean Chittenden
One of the patches that I've been sitting on and am derelict in punting upstream is the attached mmap(2) flags patch for the BSDs. Is there any chance this can be squeezed in to the PostreSQL 9.4 release? The patch is trivial in size and is used to add one flag to mmap(2) calls in dsm_impl.c.