On Wed, Oct 5, 2011 at 02:36, gabrielle wrote:
> This review was compiled from a PDXPUG group review (Dan Colish, Mark
> Wong, Brent Dombrowski, and Gabrielle Roth).
Whaat, you marked the patch as "Returned with Feedback" based on this review?
The only obvious change I need to make in response t
On Wed, Oct 5, 2011 at 02:36, gabrielle wrote:
> This review was compiled from a PDXPUG group review (Dan Colish, Mark
> Wong, Brent Dombrowski, and Gabrielle Roth).
Hi, thanks for the review!
> - Regression test requires plpythonu; it needs to work without that.
The patch contains no regressi
This review was compiled from a PDXPUG group review (Dan Colish, Mark
Wong, Brent Dombrowski, and Gabrielle Roth).
--
We all agree this is a really useful feature. The patch applies
cleanly to the current git master with git apply, it's in context
diff, and does what it's supposed to do on Ubunt
Florian Pflug writes:
> On Sep28, 2011, at 00:19 , Marti Raudsepp wrote:
>> (I'm still not sure what "adt" means)
> I always assumed it stood for "abstract data type".
Yeah, that's what I think too. Over time it's been used to hold most
code that is a SQL-callable function, many of which are no
On Sep28, 2011, at 00:19 , Marti Raudsepp wrote:
> (I'm still not sure what "adt" means)
I always assumed it stood for "abstract data type". Most of the files in this
directory seem to correspond to an SQL-level data type like intX, varchar,
tsquery, ..., and contain the I/O functions for that t
On Sat, Sep 24, 2011 at 22:57, Marti Raudsepp wrote:
> However, I now realize that it does make sense to write a separate
> simpler function for the crashed backend case with no
> vbeentry->st_changecount check loops, no checkUser, etc. That would be
> more robust and easier to review.
I implemen
