On Fri, 17 Jul 2015 at 23:14 Robert Haas wrote:
> Committed. I changed one remaining use of "proportion" to "fraction",
> fixed an OID conflict, and reverted some unnecessary whitespace
> changes.
>
Thanks Robert. Sorry I missed a "proportion" in my latest version, and
thanks for catching it.
On Fri, Jul 17, 2015 at 4:23 AM, Brendan Jurd wrote:
> On Thu, 16 Jul 2015 at 08:37 Gurjeet Singh wrote:
>> OK. Please send a new patch with the changes you agree to, and I can mark
>> it ready for committer.
>
> Done. Please find attached patch v3. I have changed "proportion" to
> "fraction",
On Fri, Jul 17, 2015 at 4:23 AM, Brendan Jurd wrote:
> On Thu, 16 Jul 2015 at 08:37 Gurjeet Singh wrote:
>> OK. Please send a new patch with the changes you agree to, and I can mark
>> it ready for committer.
>
> Done. Please find attached patch v3. I have changed "proportion" to
> "fraction",
On Thu, 16 Jul 2015 at 08:37 Gurjeet Singh wrote:
> OK. Please send a new patch with the changes you agree to, and I can mark
> it ready for committer.
>
Done. Please find attached patch v3. I have changed "proportion" to
"fraction", and made other wording improvements per your suggestions.
C
On Thu, Jun 25, 2015 at 8:43 PM, Brendan Jurd wrote:
> On Fri, 26 Jun 2015 at 06:03 Gurjeet Singh wrote:
>
>
>> s/proportion/fraction/
>>
>
> I think of these as synonymous -- do you have any particular reason to
> prefer "fraction"? I don't feel strongly about it either way, so I'm quite
> hap
On Fri, 26 Jun 2015 at 06:03 Gurjeet Singh wrote:
> Patch reviewed following the instructions on
> https://wiki.postgresql.org/wiki/Reviewing_a_Patch
>
>
Thank you for your review, Gurjeet.
> s/proportion/fraction/
>
I think of these as synonymous -- do you have any particular reason to
prefe
Patch reviewed following the instructions on
https://wiki.postgresql.org/wiki/Reviewing_a_Patch
# Submission review
- Is the patch in a patch format which has context?
Yes. Note to other reviewers: `git diff —patience` yields patch better
suited for readability
- Does it apply cleanly to the curr
On Wed, Jun 17, 2015 at 6:15 PM, Brendan Jurd wrote:
> Posting v2 of the patch, incorporating some helpful suggestions from Merlin.
Based on perfunctory scan of the code, I think this is gonna make it,
unless you draw some objections based on lack of necessity.
merlin
--
Sent via pgsql-hacker
Posting v2 of the patch, incorporating some helpful suggestions from Merlin.
Cheers,
BJ
*** a/doc/src/sgml/func.sgml
--- b/doc/src/sgml/func.sgml
***
*** 14800,14805 SELECT * FROM pg_ls_dir('.') WITH ORDINALITY AS t(ls,n);
--- 14800,14811
+pg_noti
On Thu, 18 Jun 2015 at 08:19 Merlin Moncure wrote:
>
> scratch that. that note already exists in sql-notify.html. Instead,
> I'd modify that section to note that you can check queue usage with
> your new function.
>
>
I have already done so. Under the paragraph about the queue filling up, I
ha
On Wed, Jun 17, 2015 at 5:15 PM, Merlin Moncure wrote:
> *) A note regarding the 50% (0.5) threshold raising warnings in the
> log might be appropriate here
scratch that. that note already exists in sql-notify.html. Instead,
I'd modify that section to note that you can check queue usage with
yo
On Wed, Jun 17, 2015 at 5:31 AM, Brendan Jurd wrote:
> Hello hackers,
>
> I present a patch to add a new built-in function
> pg_notify_queue_saturation().
>
> The purpose of the function is to allow users to monitor the health of their
> notification queue. In certain cases, a client connection l
On Thu, 18 Jun 2015 at 03:06 Gurjeet Singh wrote:
> I don't see this in the CF app; can you please add it there?
>
Done. I did try to add it when I posted the email, but for some reason I
couldn't connect to commitfest.postgresql.org at all. Seems fine now,
though.
Cheers,
BJ
I don't see this in the CF app; can you please add it there?
Best regards,
On Wed, Jun 17, 2015 at 3:31 AM, Brendan Jurd wrote:
> Hello hackers,
>
> I present a patch to add a new built-in function
> pg_notify_queue_saturation().
>
> The purpose of the function is to allow users to monitor the
Hello hackers,
I present a patch to add a new built-in function
pg_notify_queue_saturation().
The purpose of the function is to allow users to monitor the health of
their notification queue. In certain cases, a client connection listening
for notifications might get stuck inside a transaction, a
15 matches
Mail list logo
