Greg Stark writes:
> On 12 Mar 2016 10:58 pm, "Tom Lane" wrote:
>> I shall get rid of the const-ness, as well as the lame casting away
>> of it, and I think I will also go make buildfarm member longfin use
>> "-fno-common". It is truly sad that we apparently have no test
>> machine that enforces
On 12 Mar 2016 10:58 pm, "Tom Lane" wrote:
>
> I wrote:
> > That's confusing because it implies that -fno-common is the default,
> > which it evidently is not. But anyway, my diagnosis is that you're
> > breaking something about the linker's behavior with that switch.
> I shall get rid of the co
unfortunately, I have to admit to my disgrace, that I'm still no C programmer
after all these decades of dabbling in writing code. I just used the flags
because someone at some point told me that it was a good idea, turns out, it's
not [always]. I shall rebuild 9.5.1 without the -fno-common flag
I wrote:
> That's confusing because it implies that -fno-common is the default,
> which it evidently is not. But anyway, my diagnosis is that you're
> breaking something about the linker's behavior with that switch.
Oh! Looking closer, the core dump happens here:
const printTextFormat pg_utf8fo