Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-28 Thread Robert Haas
On Wed, Mar 27, 2013 at 11:27 AM, Thom Brown wrote: > On 27 March 2013 15:19, Robert Haas wrote: >> On Wed, Mar 27, 2013 at 10:51 AM, Thom Brown wrote: create here is referring to the sepgsql permission, not the SQL command, so it's correct as-is. >>> >>> My bad. >> >> Here's an attemp

Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Thom Brown
On 27 March 2013 15:19, Robert Haas wrote: > On Wed, Mar 27, 2013 at 10:51 AM, Thom Brown wrote: >>> create here is referring to the sepgsql permission, not the SQL >>> command, so it's correct as-is. >> >> My bad. > > Here's an attempt at reworking the whole section to be more > understandable.

Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Robert Haas
On Wed, Mar 27, 2013 at 10:51 AM, Thom Brown wrote: >> create here is referring to the sepgsql permission, not the SQL >> command, so it's correct as-is. > > My bad. Here's an attempt at reworking the whole section to be more understandable. I took the liberty of rearranging the text into bullet

Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Thom Brown
On 27 March 2013 14:50, Robert Haas wrote: > On Wed, Mar 27, 2013 at 9:09 AM, Thom Brown wrote: >> Perhaps something along the lines of: >> >> "When a CREATE FUNCTION command is executed, the install permission >> will be checked to determine whether the LEAKPROOF attribute was >> present. This p

Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Robert Haas
On Wed, Mar 27, 2013 at 9:09 AM, Thom Brown wrote: > Perhaps something along the lines of: > > "When a CREATE FUNCTION command is executed, the install permission > will be checked to determine whether the LEAKPROOF attribute was > present. This permission will also be checked when the user tries

Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Thom Brown
On 27 March 2013 12:58, Robert Haas wrote: > On Wed, Mar 27, 2013 at 8:44 AM, Thom Brown wrote: >> On 27 March 2013 12:33, Robert Haas wrote: >>> sepgsql: Support for new post-ALTER access hook. >> >> I notice that due to commit bc5334d8 I can't actually build the docs >> at the moment. >> >> Bu

Re: [HACKERS] [COMMITTERS] pgsql: sepgsql: Support for new post-ALTER access hook.

2013-03-27 Thread Robert Haas
On Wed, Mar 27, 2013 at 8:44 AM, Thom Brown wrote: > On 27 March 2013 12:33, Robert Haas wrote: >> sepgsql: Support for new post-ALTER access hook. > > I notice that due to commit bc5334d8 I can't actually build the docs > at the moment. > > But I think the language here definitely needs improvin