On Tue, May 6, 2014 at 06:24:47PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Tue, May 6, 2014 at 05:35:15PM -0400, Tom Lane wrote:
> >> But I don't see the reason why we shouldn't expect ecpg's headers to
> >> conform to our layout rules.
>
> > I don't know who ecpg got in there. Le
Bruce Momjian writes:
> On Tue, May 6, 2014 at 05:35:15PM -0400, Tom Lane wrote:
>> But I don't see the reason why we shouldn't expect ecpg's headers to
>> conform to our layout rules.
> I don't know who ecpg got in there. Let me know what you would like
> done.
What I'm suggesting is that, in
On Tue, May 6, 2014 at 05:35:15PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > Ah, found it. There is an excludes pattern file list I had forgotten
> > about; it has:
>
> > /s_lock\.h$
> > /ecpg/test/expected/
> > /snowball/libstemmer/
> > /ecpg/include/(sqlda|sqltypes)\.
Bruce Momjian writes:
> Ah, found it. There is an excludes pattern file list I had forgotten
> about; it has:
> /s_lock\.h$
> /ecpg/test/expected/
> /snowball/libstemmer/
> /ecpg/include/(sqlda|sqltypes)\.h$
> /ecpg/include/preproc/struct\.h$
> /pl/plperl/ppp
I wrote:
> I looked into this, and find that the cause of the problem is that
> pgindent touched src/interfaces/ecpg/include/sqlca.h, which is copied
> verbatim into preprocessed files by the ecpg preprocessor, so the expected
> files had to change in tandem. This amounts to a dependency, but the
On Tue, May 6, 2014 at 05:05:00PM -0400, Tom Lane wrote:
> Bruce Momjian writes:
> > On Tue, May 6, 2014 at 03:54:24PM -0400, Tom Lane wrote:
> >> But having said that, if this didn't work then there's something broken
> >> about the make rules for the ecpg tests. I'm a bit suspicious of commit
Bruce Momjian writes:
> On Tue, May 6, 2014 at 03:54:24PM -0400, Tom Lane wrote:
>> But having said that, if this didn't work then there's something broken
>> about the make rules for the ecpg tests. I'm a bit suspicious of commit
>> 69e9768e7b183d4b276d0e067a5a689580eb.
I looked into this,
On Tue, May 6, 2014 at 03:54:24PM -0400, Tom Lane wrote:
> Kevin Grittner writes:
> > Bruce Momjian wrote:
> >> Yes, I had to modify those lines before I pushed the pgindent changes so
> >> 'make installcheck-world' would pass.� It passes here for me now.� Did
> >> you do 'make maintainer-clean'
Kevin Grittner writes:
> Bruce Momjian wrote:
>> Yes, I had to modify those lines before I pushed the pgindent changes so
>> 'make installcheck-world' would pass. It passes here for me now. Did
>> you do 'make maintainer-clean' before running the tests? That might
>> help.
> It occurred to me
Kevin Grittner wrote:
> It occurred to me after my last post that I had just done a "make
> world" without any cleanup when I pulled that, and had started a
> full build from "make maintainer-clean" when you sent that. :-)
>
> I'll let you know either way when I get results from that.
Yeah, aft
Bruce Momjian wrote:
> On Tue, May 6, 2014 at 12:38:41PM -0700, Kevin Grittner wrote:
>> Tom Lane wrote:
>>> Kevin Grittner writes:
>>>
Bruce Momjian wrote:
> pgindent run for 9.4
>>>
The 13 tests above are broken by this commit. Probably the
directory should be excluded fr
On Tue, May 6, 2014 at 12:38:41PM -0700, Kevin Grittner wrote:
> Tom Lane wrote:
> > Kevin Grittner writes:
> >
> >> Bruce Momjian wrote:
> >>> pgindent run for 9.4
> >
> >> The 13 tests above are broken by this commit. Probably the
> >> directory should be excluded from pgindent processing.
>
Tom Lane wrote:
> Kevin Grittner writes:
>
>> Bruce Momjian wrote:
>>> pgindent run for 9.4
>
>> The 13 tests above are broken by this commit. Probably the
>> directory should be excluded from pgindent processing.
>
> What's broken? The buildfarm isn't complaining, and "make installcheck"
> in
Kevin Grittner writes:
> Bruce Momjian wrote:
>> pgindent run for 9.4
> The 13 tests above are broken by this commit. Probably the
> directory should be excluded from pgindent processing.
What's broken? The buildfarm isn't complaining, and "make installcheck"
in src/interfaces/ecpg/test passe
Bruce Momjian wrote:
> pgindent run for 9.4
>
> This includes removing tabs after periods in C comments, which was
> applied to back branches, so this change should not effect backpatching.
> http://git.postgresql.org/pg/commitdiff/0a7832005792fa6dad171f9cadb8d587fe0dd800
> .../test/expected/co
15 matches
Mail list logo
