Re: [HACKERS] [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding

2011-04-19 Thread Peter Eisentraut
On Sat, 2011-04-16 at 15:07 -0400, Andrew Dunstan wrote: > On 04/15/2011 04:36 PM, Peter Eisentraut wrote: > > On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote: > >> Yeah, what is the point of this?: > >> > >> -# Adjust REGRESS_OPTS because we need a UTF8 database > >> -REGRESS_OPT

Re: [HACKERS] [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding

2011-04-16 Thread Andrew Dunstan
On 04/15/2011 04:36 PM, Peter Eisentraut wrote: On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote: Yeah, what is the point of this?: -# Adjust REGRESS_OPTS because we need a UTF8 database -REGRESS_OPTS = --dbname=$(CONTRIB_TESTDB) --multibyte=UTF8 --no-locale +# We need a

Re: [HACKERS] [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding

2011-04-15 Thread Peter Eisentraut
On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote: > Yeah, what is the point of this?: > > -# Adjust REGRESS_OPTS because we need a UTF8 database > -REGRESS_OPTS = --dbname=$(CONTRIB_TESTDB) --multibyte=UTF8 --no-locale > +# We need a UTF8 database +ENCODING = UTF8 +NO_LOCALE = 1

Re: [HACKERS] [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding

2011-04-15 Thread Andrew Dunstan
On 04/15/2011 11:18 AM, Tom Lane wrote: Peter Eisentraut writes: Rename pg_regress option --multibyte to --encoding Also refactor things a little bit so that the same methods for setting test locale and encoding can be used everywhere. The buildfarm shows that this patch fails on Windows ---

Re: [HACKERS] [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding

2011-04-15 Thread Tom Lane
Peter Eisentraut writes: > Rename pg_regress option --multibyte to --encoding > Also refactor things a little bit so that the same methods for setting > test locale and encoding can be used everywhere. The buildfarm shows that this patch fails on Windows --- the contrib/unaccent regression test i