Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Michael Paquier
On Tue, Oct 25, 2016 at 1:17 PM, Tom Lane wrote: > Michael Paquier writes: >> Well... Coming back to the subject, are there any recommendations from >> committers? -std=c89 in CFLAGS does not seem to help much to detect >> extra commas in enums, even if this has been added in C99. > > My opinion

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Tom Lane
Michael Paquier writes: > Well... Coming back to the subject, are there any recommendations from > committers? -std=c89 in CFLAGS does not seem to help much to detect > extra commas in enums, even if this has been added in C99. My opinion is don't worry about it. The buildfarm will find such pro

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Thomas Munro
On Tue, Oct 25, 2016 at 2:34 PM, Peter Eisentraut wrote: > On 10/24/16 8:37 PM, Michael Paquier wrote: >> Well... Coming back to the subject, are there any recommendations from >> committers? -std=c89 in CFLAGS does not seem to help much to detect >> extra commas in enums, even if this has been ad

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Peter Eisentraut
On 10/24/16 8:37 PM, Michael Paquier wrote: > Well... Coming back to the subject, are there any recommendations from > committers? -std=c89 in CFLAGS does not seem to help much to detect > extra commas in enums, even if this has been added in C99. The only option that gives you a warning for this

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Michael Paquier
On Tue, Oct 25, 2016 at 6:59 AM, Tom Lane wrote: > Fabien COELHO writes: >>> An alternative that would be worth considering is to adopt a uniform >>> rule of // for line-ending comments and /* for all other uses. > >> Why not. As far as comments are concerned, editors usually highlight them >> in

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Tom Lane
Fabien COELHO writes: >> An alternative that would be worth considering is to adopt a uniform >> rule of // for line-ending comments and /* for all other uses. > Why not. As far as comments are concerned, editors usually highlight them > in some color, and my eyes get used to the comment color,

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Fabien COELHO
I find it annoying that "//" comments are not supported, or having to declare variables at the beginning of a block instead of when first used... I think some c99 features would be nice (variadic macros for one), but those particular two get a big "meh" from me. This is probably a matter of

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Petr Jelinek
On 24/10/16 21:11, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Alvaro Herrera writes: >>> Fabien COELHO wrote: I find it annoying that "//" comments are not supported, or having to declare variables at the beginning of a block instead of when first used... >> >>> I

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Fabien COELHO
I find it annoying that "//" comments are not supported, or having to declare variables at the beginning of a block instead of when first used... I think some c99 features would be nice (variadic macros for one), but those particular two get a big "meh" from me. Yeah. Personally, I'd want

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Bruce Momjian
On Mon, Oct 24, 2016 at 03:03:19PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > Fabien COELHO wrote: > >> I find it annoying that "//" comments are not supported, or having to > >> declare variables at the beginning of a block instead of when first used... > > > I think some c99 features w

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > Fabien COELHO wrote: > >> I find it annoying that "//" comments are not supported, or having to > >> declare variables at the beginning of a block instead of when first used... > > > I think some c99 features would be nice (varia

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Tom Lane
Alvaro Herrera writes: > Fabien COELHO wrote: >> I find it annoying that "//" comments are not supported, or having to >> declare variables at the beginning of a block instead of when first used... > I think some c99 features would be nice (variadic macros for one), but > those particular two get

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-24 Thread Alvaro Herrera
Fabien COELHO wrote: > I find it annoying that "//" comments are not supported, or having to > declare variables at the beginning of a block instead of when first used... I think some c99 features would be nice (variadic macros for one), but those particular two get a big "meh" from me. .oO( I w

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-23 Thread Fabien COELHO
C99-specific feature, and wasn't intentional in the first place. Per buildfarm member mylodon This is the second time I see that in the last couple of weeks. Would it be better to use some custom CFLAGS to detect that earlier in the review process? I have never much used gcc's std or clang ex

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

2016-10-23 Thread Michael Paquier
(Moved to -hackers) On Sun, Oct 23, 2016 at 10:57 PM, Magnus Hagander wrote: > Remove extra comma at end of enum list > > C99-specific feature, and wasn't intentional in the first place. > > Per buildfarm member mylodon This is the second time I see that in the last couple of weeks. Would it be