Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-22 Thread Tom Lane
Kevin Grittner writes: > Since I failed to find anything in our docs or C comments, and very > scant clues in the Wiki and list archives, about when to use > PGDLLIMPORT and PGDLLEXPORT I figured it might be helpful to > clarify here, and maybe add something near one of the definitions. > Based o

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-22 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 1:45 PM, Tom Lane wrote: > PGDLLIMPORT is what's needed on any backend global variable that's to > be referenced by extensions. I already pushed a fix before noticing > this thread. Thanks! Since I failed to find anything in our docs or C comments, and very scant clues

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Tom Lane
Kevin Grittner writes: > No joy with that shot in the dark. > Should I add PGDLLEXPORT to the declaration of > old_snapshot_threshold. That doesn't seem to be documented > anywhere, or have any useful comments; but it looks like it *might* > be the arcane incantation needed here. PGDLLIMPORT is

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 11:58 AM, Kevin Grittner wrote: > On Thu, Apr 21, 2016 at 9:58 AM, Kevin Grittner wrote: >> On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner >> wrote: >>> Inline initial comparisons in TestForOldSnapshot() >> >> This seems to have broken Windows builds. Is there somethin

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 9:58 AM, Kevin Grittner wrote: > On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner > wrote: >> Inline initial comparisons in TestForOldSnapshot() > > This seems to have broken Windows builds. Is there something > special that needs to be done if a function referenced from

Re: [HACKERS] [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

2016-04-21 Thread Kevin Grittner
On Thu, Apr 21, 2016 at 8:47 AM, Kevin Grittner wrote: > Inline initial comparisons in TestForOldSnapshot() This seems to have broken Windows builds. Is there something special that needs to be done if a function referenced from a contrib module changes to an inline function? -- Kevin Grittner