Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Jaime Casanova
On Fri, Nov 25, 2011 at 4:28 PM, Alvaro Herrera wrote: > > Excerpts from Dean Rasheed's message of vie nov 25 13:45:34 -0300 2011: > >> Looking back at Thom's original example, it seems odd to allow this >> syntax at all: >> >> CREATE TABLE a ( >>    num integer, >>    CONSTRAINT meow CHECK ((num

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Alvaro Herrera
Excerpts from Dean Rasheed's message of vie nov 25 13:45:34 -0300 2011: > Looking back at Thom's original example, it seems odd to allow this > syntax at all: > > CREATE TABLE a ( >num integer, >CONSTRAINT meow CHECK ((num < 20)) NOT VALID > ); > > It's not documented, but is currently

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Alvaro Herrera
Excerpts from Dean Rasheed's message of vie nov 25 13:16:29 -0300 2011: > There is a similar problem with NOT VALID check constraints on > domains. These are still being dumped as part of the CREATE DOMAIN > statement, which is invalid syntax, so they need to be dumped > separately from the domai

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Dean Rasheed
On 25 November 2011 16:16, Dean Rasheed wrote: > On 24 November 2011 21:50, Alvaro Herrera wrote: >> >> Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011: >>> Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: >>> > >>> > On 10 November 2011 23:56, Thom B

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-25 Thread Dean Rasheed
On 24 November 2011 21:50, Alvaro Herrera wrote: > > Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011: >> Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: >> > >> > On 10 November 2011 23:56, Thom Brown wrote: >> >> > > The dump correctly contains: >>

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-24 Thread Thom Brown
On 24 November 2011 21:50, Alvaro Herrera wrote: > > Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011: >> Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: >> > >> > On 10 November 2011 23:56, Thom Brown wrote: >> >> > > The dump correctly contains: >>

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-24 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of vie nov 11 00:32:33 -0300 2011: > Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: > > > > On 10 November 2011 23:56, Thom Brown wrote: > > > > The dump correctly contains: > > > > > > CREATE TABLE a ( > > >    num integer, > > >  

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-10 Thread Alvaro Herrera
Excerpts from Thom Brown's message of jue nov 10 21:28:06 -0300 2011: > > On 10 November 2011 23:56, Thom Brown wrote: > > The dump correctly contains: > > > > CREATE TABLE a ( > >    num integer, > >    CONSTRAINT meow CHECK ((num < 20)) NOT VALID > > ); > > Actually I mean incorrectly contai

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-10 Thread Thom Brown
On 10 November 2011 23:56, Thom Brown wrote: > On 18 July 2011 02:46, Alvaro Herrera wrote: >> Excerpts from Robert Haas's message of dom jul 17 20:36:49 -0400 2011: >> >>> > Does git allow for additional commit fields? That would allow for easy >>> > tracking without much additional burden on c

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-11-10 Thread Thom Brown
On 18 July 2011 02:46, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of dom jul 17 20:36:49 -0400 2011: > >> > Does git allow for additional commit fields? That would allow for easy >> > tracking without much additional burden on committers. >> >> I mean, there's git notes, but that

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-17 Thread Alvaro Herrera
Excerpts from Robert Haas's message of dom jul 17 20:36:49 -0400 2011: > > Does git allow for additional commit fields? That would allow for easy > > tracking without much additional burden on committers. > > I mean, there's git notes, but that's not exactly what we're looking > for here, and I

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-17 Thread Robert Haas
On Sun, Jul 17, 2011 at 8:44 PM, Andrew Dunstan wrote: > My understanding of git notes is that they can be added after a commit > without changing the commit - indeed that's apparently a large part of their > raison d'être: > >   A typical use of notes is to supplement a commit message without >  

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-17 Thread Andrew Dunstan
On 07/17/2011 08:36 PM, Robert Haas wrote: We do need a way to track this information. +1 on everything Josh said. Does git allow for additional commit fields? That would allow for easy tracking without much additional burden on committers. I mean, there's git notes, but that's not exactl

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-17 Thread Robert Haas
On Sun, Jul 17, 2011 at 1:20 PM, Jim Nasby wrote: > On Jul 12, 2011, at 11:30 AM, Joshua D. Drake wrote: This all becomes much easier if we keep the ads out of the commit messages, and stick to the technical side there. And find another venue for the other credit. >>> >>> I'm open t

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-17 Thread Jim Nasby
On Jul 12, 2011, at 11:30 AM, Joshua D. Drake wrote: >>> This all becomes much easier if we keep the ads out of the commit >>> messages, and stick to the technical side there. And find another >>> venue for the other credit. >> >> I'm open to ideas. > > I think the commit log isn't actually usefu

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-12 Thread Joshua D. Drake
On 07/12/2011 06:54 AM, Alvaro Herrera wrote: Excerpts from Magnus Hagander's message of mar jul 12 09:34:56 -0400 2011: Agreed. On one level I like the sponsor message, but on the other having "Sponsored by RedHat" on every Tom Lane item will get tiring. ;-) Create a macro ;) Can we add

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-12 Thread Bruce Momjian
Alvaro Herrera wrote: > Excerpts from Magnus Hagander's message of mar jul 12 09:34:56 -0400 2011: > > > > Agreed. ??On one level I like the sponsor message, but on the other > > > having "Sponsored by RedHat" on every Tom Lane item will get tiring. > > > ;-) > > > > > > Can we add text if the emp

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-12 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of mar jul 12 09:34:56 -0400 2011: > > Agreed.  On one level I like the sponsor message, but on the other > > having "Sponsored by RedHat" on every Tom Lane item will get tiring. > > ;-) > > > > Can we add text if the employer is _not_ the feature sponsor? >

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-12 Thread Magnus Hagander
On Tue, Jul 12, 2011 at 02:34, Bruce Momjian wrote: > Simon Riggs wrote: >> On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut wrote: >> > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: >> >> Robert Hass (whose name I misspelled in the commit message above) just >> >> mentioned to me (in

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-12 Thread Robert Haas
On Jul 11, 2011, at 8:34 PM, Bruce Momjian wrote: > Can we add text if the employer is _not_ the feature sponsor? I don't see that as much better. Commit messages should not be ads, IMHO. There are plenty of ways to give credit without polluting the commit log with it. ...Robert -- Sent via

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-11 Thread Bruce Momjian
Simon Riggs wrote: > On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut wrote: > > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: > >> Robert Hass (whose name I misspelled in the commit message above) just > >> mentioned to me (in an answer to my apologizing about it) that he > >> didn't t

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-03 Thread Simon Riggs
On Sun, Jul 3, 2011 at 7:51 PM, Peter Eisentraut wrote: > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: >> Robert Hass (whose name I misspelled in the commit message above) just >> mentioned to me (in an answer to my apologizing about it) that he >> didn't think that mentioning sponsors

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-03 Thread Magnus Hagander
On Sun, Jul 3, 2011 at 20:51, Peter Eisentraut wrote: > On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: >> Robert Hass (whose name I misspelled in the commit message above) just >> mentioned to me (in an answer to my apologizing about it) that he >> didn't think that mentioning sponsors f

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-07-03 Thread Peter Eisentraut
On tor, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: > Robert Hass (whose name I misspelled in the commit message above) just > mentioned to me (in an answer to my apologizing about it) that he > didn't think that mentioning sponsors for patch development was a good > idea. > > I don't think w

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-06-30 Thread Devrim GÜNDÜZ
On Thu, 2011-06-30 at 15:09 -0400, Alvaro Herrera wrote: > I don't think we have a policy for this, but I have done it for some > time now and nobody has complained, so I sort of assumed it was okay. > Besides, some of the people pouring the money in does care about it; > moreover, it provides a

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-06-30 Thread David E. Wheeler
On Jun 30, 2011, at 12:09 PM, Alvaro Herrera wrote: > Robert Hass (whose name I misspelled in the commit message above) just > mentioned to me (in an answer to my apologizing about it) that he didn't > think that mentioning sponsors for patch development was a good idea. > > I don't think we have

Re: [HACKERS] [COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-06-30 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of jue jun 30 11:58:09 -0400 2011: > Enable CHECK constraints to be declared NOT VALID > > [...] > > This patch was sponsored by Enova Financial. Robert Hass (whose name I misspelled in the commit message above) just mentioned to me (in an answer to my apol