Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Andrew Dunstan
Robert Haas wrote: On Fri, Jul 2, 2010 at 7:30 PM, Andrew Dunstan wrote: MSVC was looking for it and not finding it. I have committed a fix that I hope will fix the MSVC builds, by removing it from the list of files in libpgport. You'll need to do the same thing in 8.4... Darn

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 7:30 PM, Andrew Dunstan wrote: > MSVC was looking for it and not finding it. I have committed a fix that I > hope will fix the MSVC builds, by removing it from the list of files in > libpgport. You'll need to do the same thing in 8.4... -- Robert Haas EnterpriseDB: http:/

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Andrew Dunstan
Robert Haas wrote: I suspect that moving copydir.c into the backend will fix this, but I don't have an appropriate build environment to test. Can someone please test the attached patch? Andrew confirms that this works on mingw, so I'm going to go ahead and check it in and see what happ

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 12:38 PM, Robert Haas wrote: > On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas wrote: >> On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas wrote: >>> On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane wrote: Robert Haas writes: >>> This appears to have broken MinGW and Cygwin bu

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 11:07 AM, Robert Haas wrote: > On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas wrote: >> On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane wrote: >>> Robert Haas writes: >> This appears to have broken MinGW and Cygwin builds on the buildfarm. Well, that's not awesome.

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 10:21 AM, Robert Haas wrote: > On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane wrote: >> Robert Haas writes: > This appears to have broken MinGW and Cygwin builds on the buildfarm. >>> >>> Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if >>> this is a link

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Robert Haas
On Fri, Jul 2, 2010 at 10:18 AM, Tom Lane wrote: > Robert Haas writes: This appears to have broken MinGW and Cygwin builds on the buildfarm. >> >> Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if >> this is a link-ordering problem of some kind. > > Possibly an #ifndef FRON

Re: [HACKERS] [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Tom Lane
Robert Haas writes: >>> This appears to have broken MinGW and Cygwin builds on the buildfarm. > > Well, that's not awesome. IM-ing with Magnus now.  I'm wondering if > this is a link-ordering problem of some kind. Possibly an #ifndef FRONTEND will fix it. regards, tom la