On Sat, Feb 18, 2017 at 6:31 PM, Thomas Munro
wrote:
>> Agreed. Here's a patch like that.
>
> Oops, that had a typo in a comment. Here's a better one.
This looked fine, except that the new comment in dsa_allocate
contained an extremely long sentence which happened to contradict the
last sentenc
On Sun, Feb 19, 2017 at 12:27 PM, Thomas Munro
wrote:
> On Sun, Feb 19, 2017 at 11:27 AM, Tom Lane wrote:
>> Thomas Munro writes:
>>> On Sat, Feb 18, 2017 at 5:41 AM, Tom Lane wrote:
Robert Haas writes:
> I'm thinking we should change this to look more like the
> MemoryContextAllo
On Sun, Feb 19, 2017 at 11:27 AM, Tom Lane wrote:
> Thomas Munro writes:
>> On Sat, Feb 18, 2017 at 5:41 AM, Tom Lane wrote:
>>> Robert Haas writes:
I'm thinking we should change this to look more like the
MemoryContextAlloc interface.
>
>>> +1
>
>> Maybe something like the attached?
Thomas Munro writes:
> On Sat, Feb 18, 2017 at 5:41 AM, Tom Lane wrote:
>> Robert Haas writes:
>>> I'm thinking we should change this to look more like the
>>> MemoryContextAlloc interface.
>> +1
> Maybe something like the attached? I didn't add DSA_ALLOC_HUGE
> because there is currently no
On Sat, Feb 18, 2017 at 5:41 AM, Tom Lane wrote:
> Robert Haas writes:
>> I'm thinking we should change this to look more like the
>> MemoryContextAlloc interface. Let's have DSA_ALLOC_HUGE,
>> DSA_ALLOC_NO_OOM, and DSA_ALLOC_ZERO, just like the corresponding
>> MCXT_* flags, and a function dsa_
Robert Haas writes:
> I'm thinking we should change this to look more like the
> MemoryContextAlloc interface. Let's have DSA_ALLOC_HUGE,
> DSA_ALLOC_NO_OOM, and DSA_ALLOC_ZERO, just like the corresponding
> MCXT_* flags, and a function dsa_allocate_extended() that takes a
> flags argument. Then
On Thu, Feb 16, 2017 at 10:09 PM, Michael Paquier
wrote:
> On Fri, Feb 17, 2017 at 12:03 PM, Thomas Munro
> wrote:
>> On Fri, Feb 17, 2017 at 11:34 AM, Thomas Munro
>> wrote:
>>> On Fri, Feb 17, 2017 at 7:02 AM, Robert Haas wrote:
http://git.postgresql.org/pg/commitdiff/9acb85597f1223ac26a
