Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-02-11 Thread Magnus Hagander
Magnus Hagander wrote: > On Tue, Jan 30, 2007 at 11:45:24AM -0500, Tom Lane wrote: >> Magnus Hagander <[EMAIL PROTECTED]> writes: >>> But I guess maybe the added check has to be not just (!syslogger_started) >>> but (!syslogger_started && is_postmaster)? >> That would at least get you out of the pr

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-31 Thread Magnus Hagander
On Tue, Jan 30, 2007 at 11:45:24AM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > But I guess maybe the added check has to be not just (!syslogger_started) > > but (!syslogger_started && is_postmaster)? > > That would at least get you out of the problem of having to trans

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > But I guess maybe the added check has to be not just (!syslogger_started) > but (!syslogger_started && is_postmaster)? That would at least get you out of the problem of having to transmit the syslogger_started flag to the backends...

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Magnus Hagander
On Tue, Jan 30, 2007 at 10:32:14AM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > So I still tthink it's a good idea. Even though it doesn't solve every > > case, it solves a lot of them I think. And more importantly on that, I > > don't see how it would *break* anything (

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > So I still tthink it's a good idea. Even though it doesn't solve every > case, it solves a lot of them I think. And more importantly on that, I > don't see how it would *break* anything (given that it still fires only > when running as a service, when e

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-30 Thread Magnus Hagander
On Mon, Jan 29, 2007 at 09:56:16PM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > I'm thinking we need a check in elog.c on the: > > if ((!Redirect_stderr || am_syslogger) && pgwin32_is_service()) > > write_eventlog(edata->elevel, buf.data);

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-29 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > I'm thinking we need a check in elog.c on the: > if ((!Redirect_stderr || am_syslogger) && pgwin32_is_service()) > write_eventlog(edata->elevel, buf.data); > line, that checks if the syslogger process has been started

Re: [HACKERS] [BUGS] Missing error message on missing ssl-key-files

2007-01-29 Thread Magnus Hagander
Harald Armin Massa wrote: > PostgreSQL 8.1.5 and 8.2.1 > > both on W2K3, installed from the standard win32 msi installer. > > Problem: > > in postgresql.conf > > ssl=on > > but the files server.key etc. are NOT present. > > Result: PostgreSQL service does not start. And no error message in an