Re: [HACKERS] [BUGS] BUG #8167: false EINVAL -22 for opening a file

2013-05-16 Thread Robert Haas
On Thu, May 16, 2013 at 11:55 AM, Tom Lane wrote: > I've not really reviewed fd.c for other instances of the same bug, > but I do see some places where there are DO_DB(...) debug calls in > places where errno had better not change. I'm thinking maybe we should > improve that macro to include save

Re: [HACKERS] [BUGS] BUG #8167: false EINVAL -22 for opening a file

2013-05-16 Thread Tom Lane
nel...@monkey.org writes: > RhodiumToad asked me to report "pg in PathNameOpenFile / mdopen is > assuming that errno is preserved over calls to free() which is not > required by the spec" Good catch! The proximate problem appears to be this bit in PathNameOpenFile: vfdP->fd = BasicOpenFi