Re: [HACKERS] [BUGS] BUG #6425: Bus error in slot_deform_tuple

2012-02-05 Thread Simon Riggs
On Sat, Feb 4, 2012 at 6:49 PM, Tom Lane wrote: > Simon Riggs writes: >> The cause here is data changing underneath the user. Your patch solves >> the most obvious error, but it still allows other problems if applying >> the backup block changes data. If the backup block doesn't do anything >> at

Re: [HACKERS] [BUGS] BUG #6425: Bus error in slot_deform_tuple

2012-02-04 Thread Tom Lane
Simon Riggs writes: > The cause here is data changing underneath the user. Your patch solves > the most obvious error, but it still allows other problems if applying > the backup block changes data. If the backup block doesn't do anything > at all then we don't need to apply it either. This is no

Re: [HACKERS] [BUGS] BUG #6425: Bus error in slot_deform_tuple

2012-02-04 Thread Simon Riggs
On Sat, Feb 4, 2012 at 6:37 PM, Simon Riggs wrote: > Patch to do that attached --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index 99a431a

Re: [HACKERS] [BUGS] BUG #6425: Bus error in slot_deform_tuple

2012-02-04 Thread Simon Riggs
On Fri, Feb 3, 2012 at 6:45 AM, Tom Lane wrote: > The reason it is relevant > to our current problem is that even though RestoreBkpBlocks faithfully > takes exclusive lock on the buffer, *that is not enough to guarantee > that no one else is touching that buffer*.  Another backend that has > alre