Heikki Linnakangas wrote:
> Well, looking at the callers, most if not all of them seem to actually
> pass a palloc'd copy, allocated by text_to_cstring().
>
> Should we throw a NOTICE like vanilla truncate_identifier() does?
>
> I feel it would be better to just call truncate_identifier() tha
On 02/06/10 09:46, Takahiro Itagaki wrote:
Heikki Linnakangas wrote:
Hmm, seems that dblink should call truncate_identifier() for the
truncation, to be consistent with truncation of table names etc.
Hmmm, we need the same routine with truncate_identifier(), but we hard
to use the function b
Heikki Linnakangas wrote:
> Hmm, seems that dblink should call truncate_identifier() for the
> truncation, to be consistent with truncation of table names etc.
Hmmm, we need the same routine with truncate_identifier(), but we hard
to use the function because it modifies the input buffer direct
On 01/06/10 05:55, Takahiro Itagaki wrote:
"Takahiro Itagaki" wrote:
Contib/dblink module seems to have a bug in handling
connection names in NAMEDATALEN-1 bytes.
Here is a patch to fix the bug. I think it comes from wrong usage
of snprintf(NAMEDATALEN - 1). It just copies 62 bytes + \0.
In
"Takahiro Itagaki" wrote:
> Bug reference: 5487
> Logged by: Takahiro Itagaki
> Email address: itagaki.takah...@oss.ntt.co.jp
> Description:dblink failed with 63 bytes connection names
> Details:
>
> Contib/dblink module seems to have a bug in handling
> connection n
