Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-12 Thread Magnus Hagander
On Fri, May 11, 2012 at 3:35 PM, Tom Lane wrote: > Magnus Hagander writes: >> On Thu, May 10, 2012 at 6:52 PM, Tom Lane wrote: >>> Oh ... while hacking win32 PGSemaphoreLock I saw that it has a *seriously* >>> nasty bug: it does not reset ImmediateInterruptOK before returning. >>> How is it that

Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-11 Thread Tom Lane
Magnus Hagander writes: > On Thu, May 10, 2012 at 6:52 PM, Tom Lane wrote: >> Oh ... while hacking win32 PGSemaphoreLock I saw that it has a *seriously* >> nasty bug: it does not reset ImmediateInterruptOK before returning. >> How is it that Windows machines aren't falling over constantly? > Hmm

Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-11 Thread Magnus Hagander
On Thu, May 10, 2012 at 6:52 PM, Tom Lane wrote: > I wrote: >> Hence I think we oughta swap the order of those two array >> elements.  (Same issue in PGSemaphoreLock, btw, and I'm suspicious of >> pgwin32_select.) > > Oh ... while hacking win32 PGSemaphoreLock I saw that it has a *seriously* > nas

Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-10 Thread Tom Lane
I wrote: > Hence I think we oughta swap the order of those two array > elements. (Same issue in PGSemaphoreLock, btw, and I'm suspicious of > pgwin32_select.) Oh ... while hacking win32 PGSemaphoreLock I saw that it has a *seriously* nasty bug: it does not reset ImmediateInterruptOK before return

Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-10 Thread Tom Lane
Magnus Hagander writes: > On May 10, 2012 4:59 PM, "Tom Lane" wrote: >> I spent some time staring at the Windows WaitLatchOrSocket code myself. >> The only thing I could find that seemed wrong is that in the event >> array, we list the latch's event before pgwin32_signal_event. The >> Microsoft

Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-10 Thread Magnus Hagander
On May 10, 2012 4:59 PM, "Tom Lane" wrote: > > I wrote: > > Last night I changed the stats collector process to use > > WaitLatchOrSocket instead of a periodic forced wakeup to see whether > > the postmaster has died. This morning I observe that several Windows > > buildfarm members are showing r

Re: [HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-10 Thread Tom Lane
I wrote: > Last night I changed the stats collector process to use > WaitLatchOrSocket instead of a periodic forced wakeup to see whether > the postmaster has died. This morning I observe that several Windows > buildfarm members are showing regression test failures caused by > unexpected "pgstat w

[HACKERS] "pgstat wait timeout" just got a lot more common on Windows

2012-05-09 Thread Tom Lane
Last night I changed the stats collector process to use WaitLatchOrSocket instead of a periodic forced wakeup to see whether the postmaster has died. This morning I observe that several Windows buildfarm members are showing regression test failures caused by unexpected "pgstat wait timeout" warnin