Re: [HACKERS] "bad key in cancel request"

2007-11-04 Thread Neil Conway
On Sun, 2007-11-04 at 11:06 -0500, Tom Lane wrote: > No, if it's intended for the log it should be LOG. Your other proposals > are actually *less* likely to get to where the DBA could see them. Good point. I suggested WARNING because that suggests that something is awry, whereas LOG is used for r

Re: [HACKERS] "bad key in cancel request"

2007-11-04 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > ereport(DEBUG2, > (errmsg_internal("bad key in cancel request for process %d", > backendPID))); > I think this ought to be logged at a higher level than DEBUG2: for one > thing, it is a potential security issue the DBA might wa

[HACKERS] "bad key in cancel request"

2007-11-04 Thread Neil Conway
I noticed that processCancelRequest() emits a log message at DEBUG2 when it receives a cancel request with a bad key or for a non-existent PID. For example, ereport(DEBUG2, (errmsg_internal("bad key in cancel request for process %d", backendPID))); I think this ought