Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-09 Thread Alvaro Herrera
Greg Smith wrote: > On Tue, 9 Sep 2008, Magnus Hagander wrote: > >>> (I dropped the "default" stuff for now, as it doesn't seem that a >>> consensus has been reached on that topic.) >> >> This is one of the reasons I suggested keeping that one as a separate >> patch in the first place. The other ma

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-09 Thread Greg Smith
On Tue, 9 Sep 2008, Magnus Hagander wrote: (I dropped the "default" stuff for now, as it doesn't seem that a consensus has been reached on that topic.) This is one of the reasons I suggested keeping that one as a separate patch in the first place. The other main reason being that once it gets

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-09 Thread Magnus Hagander
Alvaro Herrera wrote: > Tom Lane wrote: >> Alvaro Herrera <[EMAIL PROTECTED]> writes: >>> Tom Lane wrote: > >>> Hmm, I didn't recheck after Greg's patch, but in mine, it doesn't, >>> because the location is saved as "reset location" and restored when the >>> variable is reset. It worked fine in a

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-08 Thread Greg Smith
On Mon, 8 Sep 2008, Alvaro Herrera wrote: (I dropped the "default" stuff for now, as it doesn't seem that a consensus has been reached on that topic.) I have multiple GUC-related projects that are all stalled waiting for that capability to be added. The only thing there wasn't clear consensu

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-08 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > > Hmm, I didn't recheck after Greg's patch, but in mine, it doesn't, > > because the location is saved as "reset location" and restored when the > > variable is reset. It worked fine in all cases I tested. > > Hmm

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Tom Lane
Greg Smith <[EMAIL PROTECTED]> writes: > On Tue, 2 Sep 2008, Tom Lane wrote: >>> How about having two new columns "reset value" and "boot value"? >> >> Like it better than "default value" ... > It's being a bit pedantic at the expense of the user, but I don't really > care that much here. I exp

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-03 Thread Greg Smith
On Tue, 2 Sep 2008, Tom Lane wrote: How about having two new columns "reset value" and "boot value"? Like it better than "default value" ... It's being a bit pedantic at the expense of the user, but I don't really care that much here. I exposed the boot_val and described it in the documen

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-02 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Greg just sent me this patch, augmenting the one I sent to add source > > file and line to GUC vars; Greg's patch adds a column with the default > > value of each var. > > I haven't tested, but doesn't this lose the source-location i

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I haven't tested, but doesn't this lose the source-location information >> if a setting acquired from the config file is temporarily overridden via >> SET (consider SET LOCAL, or a SET in a rolled-back xact)? It'll go to >> NULL and n

Re: [EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-02 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Greg just sent me this patch, augmenting the one I sent to add source > file and line to GUC vars; Greg's patch adds a column with the default > value of each var. I haven't tested, but doesn't this lose the source-location information if a setting acqu

[EMAIL PROTECTED]: Re: [HACKERS] [patch] GUC source file and line number]

2008-09-01 Thread Alvaro Herrera
Greg just sent me this patch, augmenting the one I sent to add source file and line to GUC vars; Greg's patch adds a column with the default value of each var. I forward it to -hackers to have a public Message-Id to link to in the Commitfest page. -- Alvaro Herrera