Re: [HACKERS] Review of Synchronous Replication patches

2010-07-24 Thread zb
> Hello Zoltán, > > Thanks for your reply! >> Instead, I will post a patch that unifies my configuration choices with >> Fujii's patch. > Please know that Fujii's patch is also a work in progress. Yes, I know that. But working from Fujii's last public patch or from his GIT tree makes my patch easi

Re: [HACKERS] Review of Synchronous Replication patches

2010-07-24 Thread zb
Hi, > ... Off the list I've received word from Zoltan > that work on a new patch is planned. It would be great if ideas from > both patches could be merged into one. ... > * Does it follow SQL spec, or the community-agreed behavior? > A: Unknown, though the choices in guc parameters suggest the

Re: [HACKERS] lock_timeout GUC patch - Review

2010-07-22 Thread zb
Hi, first, thanks for the review. > Hi, I've been reviewing this patch for the last few days. Here it is : > > * Submission review > * Is the patch in context diff format? > Yes > > * Does it apply cleanly to the current CVS HEAD? > Yes > > * Does it include reasonable tests, necessary doc