[HACKERS] Question about an inconsistency - 2

2016-07-19 Thread pet...@gmail.com
Hi, In file postgresql-9.4.4/src/backend/utils/adt/format_type.c function format_type_internal line 159, shouldn’t be used array_base_type instead of type_oid? In line 153 it is searched for array_base_type and thus shouldn’t we use it (ie., array_base_type) to report that the type is not found.

[HACKERS] Question about an inconsistency - 3

2016-07-19 Thread pet...@gmail.com
Hi, In file postgres/postgresql-9.4.4/src/timezone/zic.c function stringzone line 2091we have if (stringrule(result, stdrp, dstrp->r_stdoff, zp->z_gmtoff) != 0) Is it ok to have as the 3rd argument dstrp->r_stdoff or should we have stdrp->r_stdoff? In line 2085 dstrp is used in both arguments.

[HACKERS] Question about an inconsistency - 1

2016-07-06 Thread pet...@gmail.com
Hi, I have a question regarding the source code in file pg_proc.h (postgresql-9.4.4). At line 1224 (copied below) why the 28th identifier is timestamp_eq? DATA(insert OID = 1152 ( timestamptz_eq PGNSP PGUID 12 1 0 0 0 f f f t t f i 2 0 16 "1184 1184" _null_ _null_ _null_ _null_ timestamp_eq