Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-15 Thread ivan babrou
Is there any hope to see it in libpq? If so, can anyone review latest version of my patch? On 10 July 2013 11:49, ivan babrou wrote: > On 9 July 2013 18:43, Andres Freund wrote: >> On 2013-07-05 21:28:59 +0400, ivan babrou wrote: >>> Hi, guys! I made a quick patch to support

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-10 Thread ivan babrou
On 9 July 2013 18:43, Andres Freund wrote: > On 2013-07-05 21:28:59 +0400, ivan babrou wrote: >> Hi, guys! I made a quick patch to support floating number in >> connect_timeout param for libpq. This will treat floating number as >> seconds so this is backwards-compatible. I d

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-10 Thread ivan babrou
On 9 July 2013 19:17, Dmitriy Igrishin wrote: > > > > 2013/7/9 Merlin Moncure >> >> On Fri, Jul 5, 2013 at 12:28 PM, ivan babrou wrote: >> > Hi, guys! I made a quick patch to support floating number in >> > connect_timeout param for libpq. This will tre

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-09 Thread ivan babrou
On 9 July 2013 17:59, Markus Wanner wrote: > Ian, > > On 07/05/2013 07:28 PM, ivan babrou wrote: >> - /* >> - * Rounding could cause connection to fail; need at >> least 2 secs >> - */ > > Y

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-09 Thread ivan babrou
On 9 July 2013 12:20, Markus Wanner wrote: > On 07/09/2013 09:15 AM, ivan babrou wrote: >> Database server lost network — boom, 2 seconds delay. What's the point then? > > Oh, I see. Good point. It could still improve connection time during > normal operation, though.

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-09 Thread ivan babrou
On 9 July 2013 11:05, Markus Wanner wrote: > On 07/08/2013 08:31 PM, ivan babrou wrote: >> Seriously, I don't get why running 150 poolers is easier. > > Did you consider running pgbouncer on the database servers? > > Regards > > Markus Wanner Database server lost

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-08 Thread ivan babrou
On 8 July 2013 20:40, David E. Wheeler wrote: > On Jul 8, 2013, at 7:44 AM, ivan babrou wrote: > >>> Can you tell me why having ability to specify more accurate connect >>> timeout is a bad idea? >> >> Nobody answered my question yet. > > From an earlier

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-08 Thread ivan babrou
On 5 July 2013 23:47, ivan babrou wrote: > On 5 July 2013 23:26, Tom Lane wrote: >> ivan babrou writes: >>> If you can figure out that postgresql is overloaded then you may >>> decide what to do faster. In our app we have very strict limit for >>> connect tim

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread ivan babrou
On 5 July 2013 23:26, Tom Lane wrote: > ivan babrou writes: >> If you can figure out that postgresql is overloaded then you may >> decide what to do faster. In our app we have very strict limit for >> connect time to mysql, redis and other services, but postgresql has &g

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread ivan babrou
timeouts matter. On 5 July 2013 22:20, Tom Lane wrote: > ivan babrou writes: >> Hi, guys! I made a quick patch to support floating number in >> connect_timeout param for libpq. > > What exactly is the use case for that? It seems like extra complication > for something with

[HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread ivan babrou
Hi, guys! I made a quick patch to support floating number in connect_timeout param for libpq. This will treat floating number as seconds so this is backwards-compatible. I don't usually write in C, so there may be mistakes. Could you review it and give me some feedback? -- Regards, Ian Babrou http