I think it is desirable that this patch should be resubmitted for the next
CommitFest for further review and testing mentioned above. So I'd like to mark
this patch as Returned with Feedback. Is it OK?
Sounds like a good idea. Thanks for the review!
Ian Link
Etsuro F
the patch with those still
there.
I should have a new patch soonish, hopefully. Thanks for your feedback!
Ian
Ian Link wrote:
8. I think there are no issues in this patch. However, I have one question: how
this patch works in the case where gin_fast_limit/fast_cache_size = 0? In this
case, i
Hi Etsuro,
Sorry for the delay but I have been very busy with work. I have been
away from postgres for a while, so I will need a little time to review
the code and make sure I give you an informed response. I'll get back to
you as soon as I am able. Thanks for understanding.
Ian
onvenience. It auto-increments with each new query, giving you a different
temporary table for each query. Seems pretty helpful to me.
On Tue, Jul 2, 2013 at 6:16 PM, Robert Haas wrote:
> On Tue, Jul 2, 2013 at 8:16 PM, ian link wrote:
> > We covered that earlier in the email thread, b
I'm fine with moving the operators over to functions. I just don't want to
implement anything that is against best practice. If we are OK with that
direction, I'll go ahead and start on the new patch.
Ian
On Mon, Jul 1, 2013 at 9:03 PM, Tom Lane wrote:
> Craig Ringer writes:
> > On 07/02/2013
>
> I haven't been able to find any real documentation on this feature,
> other than the additions to the psql help.
You're right, I missed that in my review. I agree that it needs some more
documentation.
What is "ans"?
We covered that earlier in the email thread, but it's the current name for
has one huge advantage: simplicity. The client is a
classical command-line tool, and as such it delegates some of the
functionality to external programs, like pager or terminal.
I'm pretty sure that your terminal
emulator has a 'find' function that would allow you to quick
r do you need any
help getting them done?
On Sun, Jun 30, 2013 at 11:35 PM, Pavel Stehule wrote:
> Hello
>
> 2013/7/1 ian link :
> > Not sure about all of your suggestions. Let me see if I can clarify what
> > you're looking for.
> >
> >>
> >> * s
Definitely not this week. Hopefully for next commit fest.
On Sun, Jun 30, 2013 at 9:56 PM, Josh Berkus wrote:
> On 06/30/2013 08:54 PM, ian link wrote:
> > I found some time and I think I am up to speed now. I finally figured out
> > how to add new operator strategies and mad
nal RANGE support. I think I will address those
after the opclass stuff is done.
Thanks!
Ian
On Sat, Jun 22, 2013 at 4:38 PM, ian link wrote:
> Thanks Craig! That definitely does help. I probably still have some
> questions but I think I will read through the rest of the code before
>
Not sure about all of your suggestions. Let me see if I can clarify what
you're looking for.
> * simply decision if content should be stored in history or not,
Do you mean that the user should use a flag to place the result of a query
into the history?
like:
--ans SELECT * FROM cities...
Not su
No worries! :)
On Fri, Jun 28, 2013 at 12:20 AM, Pavel Stehule wrote:
> Hello
>
> It's look like my bug - wrong compilation
>
> I am sorry
>
> Pavel
>
> 2013/6/28 ian link :
> > I just applied the patch to a clean branch from the latest master. I
> >
14.i686 readline-6.1-2.fc14.i386
> (gdb) bt
> #0 0x0805aab4 in get_prompt (status=PROMPT_READY) at prompt.c:98
> #1 0x0805786a in MainLoop (source=0xc45440) at mainloop.c:134
> #2 0x0805a68d in main (argc=2, argv=0xbfcf2894) at startup.c:336
>
> Regards
>
> Pavel Stehule
&g
>
> It's better to post a review as a reply to the message which contains
> the patch.
Sorry about that, I did not have the email in my inbox and couldn't figure
out how to use the old message ID to send a reply. Here is the thread:
http://www.postgresql.org/message-id/flat/caecsyxjri++t3pevdyzawh
Or earlier,
whatever works for you. Also, this is my first time reviewing a patch, so
please let me know if I can improve on anything. Thanks!
Ian Link
ian link
Saturday, June
22, 2013 7:03 PM
Looks like my
community login is still not working. No rush, just wanted to let you
know. Thanks!Ian
Ian Link
Tuesday, June 18,
2013 11:41 AM
No worries! I'll just wait until it's up again.
Looks like my community login is still not working. No rush, just wanted to
let you know. Thanks!
Ian
On Tue, Jun 18, 2013 at 11:41 AM, Ian Link wrote:
>
> No worries! I'll just wait until it's up again.
> Thanks
> Ian
>
> Kevin Grittner
> Tuesday, June
Thanks Craig! That definitely does help. I probably still have some
questions but I think I will read through the rest of the code before
asking. Thanks again!
Ian
> Craig Ringer
> Friday, June 21, 2013 8:41 PM
>
> On 06/22/2013 03:30 AM, ian link wrote:
>>
>> Forgive m
Forgive my ignorance, but I don't entirely understand the problem. What
does '+' and '-' refer to exactly?
Thanks!
On Fri, Jun 21, 2013 at 4:35 AM, Hitoshi Harada wrote:
>
>
>
> On Fri, Jun 21, 2013 at 3:20 AM, Craig Ringer wrote:
>
>> On 06/21/2013 05:32 PM, Hitoshi Harada wrote:
>>
>> > I also
aseswhere
that hack affects the behavior.
I am honestly not 100% certain why these functions have issues, but this
seems a good place to start investigating.
Ian Link
Craig Ringer
Thursday, June
20, 2013 7:37 PM
Good to know,
and welcome.I hope the links to the archived
I am currently looking
into this feature. However, as I am quite new to Postgres, I think it
might take me a while to get up to speed. Anyways, I would also
appreciate another round of discussion on the future of the windowing
functions.
Ian Link
Craig Ringer
Thursday
ays if you don't already have a login.--Kevin GrittnerEnterpriseDB:
http://www.enterprisedb.comThe Enterprise PostgreSQL Company
Kevin Grittner
Tuesday, June 18,
2013 9:09 AM
Ian Link wrote:
This patch contains a performance improvement for the fast gin
cache.
Our test
22 matches
Mail list logo
