Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-26 Thread gabrielle
t; > promotion to increase the number of non-submitter reviewers? > > > > a) yes > > b) no > > c) yes, but submitters and committers should get it too > I was going to go with b until I saw the suggestion for a PgCon ticket. I really like that idea. gabrielle

[HACKERS] Clarification of certain SQLSTATE class

2013-01-24 Thread gabrielle
LSTATE of 02000. I thought that Pg always generated an appropriate SQLSTATE code, and that it was just up to $client code to pick up that value, but that doesn't seem to be the case. Is this part of the SQL standard we don't implement? Thanks! gabrielle

Re: [HACKERS] [PATCH] Log crashed backend's query v3

2011-10-06 Thread gabrielle
x. :) > Here is version 3 of the patch. Looks good, and performs as advertised. Thanks! gabrielle -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-10-04 Thread gabrielle
This review was compiled from a PDXPUG group review (Dan Colish, Mark Wong, Brent Dombrowski, and Gabrielle Roth). -- We all agree this is a really useful feature. The patch applies cleanly to the current git master with git apply, it's in context diff, and does what it's suppose

Re: [HACKERS] Explicit psqlrc

2010-06-23 Thread gabrielle
s like with this patch that's far from being the case. Correct. Each is handled individually. Should I continue to check on ON_ERROR_ROLLBACK results, or bounce this back to the author? gabrielle -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your s

Re: [HACKERS] Explicit psqlrc

2010-06-21 Thread gabrielle
of transaction block" messages. > I would like multiple -c commands also, as well as a mix of -f and -c. > Can we add that at the same time please? I'll leave this one for someone else to answer. :) gabrielle -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.o

[HACKERS] Review: psql-wrap-formatting/Unicode UTF-8 table formatting for psql text output

2009-11-18 Thread gabrielle
view: * looks good to me * fits in with the surrounding code * no compiler warnings, no crashes * complete & understandable docs Personally, I think this rocks. It really improves the readability of query output. gabrielle -- on behalf of the PDXPUG Patch Review Team (Dan, Ma

Re: [HACKERS] Commitfest Code Sprint with PUGs

2009-09-14 Thread gabrielle
On Fri, Jul 10, 2009 at 4:06 PM, Josh Berkus wrote: > Gabrielle of PDXPUG volunteered that PUG to hold a "code sprint" in > coordination with a commitfest sometime soon.  For that event, the PDXPUG > members would take on a dozen or so patches, compile and review them and &

Re: [HACKERS] Commitfest Code Sprint with PUGs

2009-09-03 Thread gabrielle
On Thu, Sep 3, 2009 at 10:58 AM, Robert Haas wrote: > On Thu, Sep 3, 2009 at 1:54 PM, Webb Sprague wrote: >> Hi Josh et al, >> >> I believe we are all still interested (Selena? Gabrielle?) Heck yes! >> How about this: 6:00 Tuesday evening (Pacific), the three of us (an

Re: [HACKERS] Commitfest Code Sprint with PUGs

2009-07-20 Thread gabrielle
(cc'ing Webb Sprague because I believe this was actually his idea...don't want to take credit for it if so. :) ) On Fri, Jul 10, 2009 at 4:06 PM, Josh Berkus wrote: > Gabrielle of PDXPUG volunteered that PUG to hold a "code sprint" in > coordination with a commitfes