is caught by checksums. I am
not familiar with WAL protocol - do we have enough checksums when writing
it out and on the wire? I suspect there are much more things PostgreSQL can
do to be more resilient, and at least detect corruptions earlier.
--
Vladimir Rusinov
PostgreSQL SRE, Google Ireland
Goog
and human-
readable and writable and generally easy to debug. I'm not bold enough to
propose PostgreSQL to use it, but I'd be happy to see ideas from it to be
used elsewhere.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047
smime.p7s
Description: S/MIME Cryptographic Signature
m now
given there are patches above that rename other things as well.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047
smime.p7s
Description: S/MIME Cryptographic Signature
t internal function and filenames, but that
could also be done if there's desire for this.
I'd like to have most user-visible changed checked in earlier. Stuff like
internal refactoring can be done pretty much at any point in development
cycle.
--
Vladimir Rusinov
Storage SRE, Google Irel
On Wed, Jan 18, 2017 at 12:28 PM, Michael Paquier wrote:
> On Wed, Jan 18, 2017 at 8:15 PM, Vladimir Rusinov
> wrote:
> > On the topic of binaries, there's going to be another patch renaming
> them.
> > Those will have no aliases as it's trivial to work-around
k-around (symlinks, shell
scripts, etc) and not so trivial to implement in a portable way.
I'm used to workflows with lots of small commits, so I was not able to
force myself to include all of the renames in one diff.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon
e maintenance burden than just keeping aliases.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047
smime.p7s
Description: S/MIME Cryptographic Signature
Stephen, Tom, David F, Vik, Bruce M, David Steele, Robert
Haas => 7
- yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N, Vladimir,
Simon R => 7
- avoid renaming altogether: Fujii-san => 1
Duh. Folks, you are not making it easy. :) Looks like we need one more vote.
--
Vladim
ts on this thread, keeping your patch
> with the compatibility table is the best move for now. Even if we end
> up by having a version without aliases, that will be just code to
> remove in the final version.
>
Indeed, it is trivial to kill aliases.
New version of the patch attached.
e
pg_xlogfile_name| pg_wal_file_name
pg_xlogfile_name_offset | pg_wal_file_name_offset
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047
diff --git a/contrib/bloom
used
pg_last_xlog_receive_location | pg_last_wal_receive_location
pg_last_xlog_replay_location| pg_last_wal_replay_location
pg_switch_xlog | pg_switch_wal
pg_xlog_location_diff | pg_wal_location_diff
pg_xlog_replay_pause | pg_wal_replay_pause
pg_xlog_replay_
function names. I've used 'recovery' instead of 'xlog_replay' and
used 'wal_file' instead of 'xlogfile'. Does it make sense?
- Release notes. I was unable to find a draft for 10.0. How do I make sure
these renames are not forgotten?
--
Vladimir Rusinov
Storag
rd
deadline for removal in 11.0.
This way we are nicer to people who maintain their tools and read release
notes via giving them more time, and nicer to ourselves via cleaning legacy
stuff relatively soon.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barro
nd maybe other hosting providers)
and ask them to migrate to new function names. This is of course will not
fix everything, but it would be a significant chunk. I suspect a lot of
private tools/scripts borrow snippets from github as well.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Go
On Thu, Dec 29, 2016 at 5:59 PM, Stephen Frost wrote:
> I have a pretty strong
> feeling about this particular change being worthwhile and also pretty
> long overdue.
>
Yeah, sorry for that. I should be able to make some progress early January.
--
Vladimir Rusinov
Storage SRE, Go
Now, I'm not sure whether it is worth maintaining function aliases.
Assuming these are indeed trivial (can somebody point me to example?) I see
roughly the same amount of downsides both ways.
Having aliases raises additional questions:
- do we keep them documented (probably not?)
- do we keep th
ests pass.
I have no further comments, although since I'm not experienced Postgres
reviewer, commiter may want to take another look before merging.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Irelan
es little sense.
Ack. I was not sure what patch size is preferred here. Will continue with a
patch in original thread later.
Thanks for feedback!
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ir
the need to consult the log archive, thus
+making this a completely standalone backup.
I suggest "method none" instead of "option
none". I found the word "option" confusing in that
sentence.
--
Vladimir Rusinov
Storage SRE, Google Ireland
G
cally
freezes behavior of psql and makes e.g. server tests depend not only server
behavior but also on piece of irrelevant client-only code.
I could imagine a test system that is both has more-or-less human-readable
expected.out files and does not depend on exact decorations added by psql.
--
Vlad
rge just these, as it will not help
people with whitespace-eating editors.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047
smime.p7s
Description: S/MIME Cryptographic Signature
output files as a
separate issue.
One way to ease the pain is to remove trailing whitespaces in all supported
branches via separate patches.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registrati
On Wed, Dec 14, 2016 at 4:50 PM, Tom Lane wrote:
> Vladimir Rusinov writes:
> > Therefore, I propose this patch.
>
> Right now is a really bad time to do that; what it will mostly accomplish
> is to break back-patching of doc fixes for little benefit.
>
ack. As I said, it
They are considered bad practice in many style guides and many editors
configured to stip them on every save.
Such editors will produce spurious diffs when editing the documentation.
Therefore, I propose this patch.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon
On Wed, Dec 14, 2016 at 4:07 PM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 12/13/16 12:47 PM, Vladimir Rusinov wrote:
> > Based on discussion in
> > https://www.postgresql.org/message-id/CAE1wr-w%
> 3DLE1cK5uG_rmAh-VBxc4_Bnw-gAE3qSqL-%3Dt
Based on discussion in
https://www.postgresql.org/message-id/CAE1wr-w%3DLE1cK5uG_rmAh-VBxc4_Bnw-gAE3qSqL-%3DtWwvLvjQ%40mail.gmail.com
.
Tested via regression tests.
To be applied in master only and to be included in 10.0.
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd
On Fri, Dec 2, 2016 at 1:59 PM Michael Paquier
wrote:
> On Fri, Dec 2, 2016 at 8:28 PM, Vladimir Rusinov
> wrote:
> > I guess it would make sense to do all of it in 10.0.
> > I'm new here, so not very sure about process. How many commit fests
> could I
> > expe
On Fri, Dec 2, 2016 at 2:02 AM Michael Paquier
wrote:
> On Fri, Dec 2, 2016 at 3:21 AM, Robert Haas wrote:
> > On Thu, Dec 1, 2016 at 10:29 AM, Vladimir Rusinov
> wrote:
> >> I've found myself wondering "where is my xlog" after running
> >> pg_swit
_recievexlog to pg_revievewal (and others in bin/)?
- rename pg_xlogdump to pg_waldump?
- if we do rename, should we keep aliases for functions and symlinks for
tools?
- anything else?
--
Vladimir Rusinov
Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Irelan
Performance review
===
n/a
Coding review
=======
LGTM
Architecture review
==
n/a
--
Vladimir Rusinov
Bigtable SRE
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047
On Mon, Oct 3, 2016 at 5:44 AM, Micha
30 matches
Mail list logo
