Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-01-29 Thread Steeve Lennmark
New patch attached with the following changes: On Thu, Jan 23, 2014 at 11:01 AM, Steeve Lennmark wrote: > On Thu, Jan 23, 2014 at 2:06 AM, Peter Eisentraut wrote: > >> I'm not totally happy with the choice of ":" as the mapping separator, >> because that

Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-01-23 Thread Steeve Lennmark
Peter, On Thu, Jan 23, 2014 at 2:06 AM, Peter Eisentraut wrote: > > I'm tempted to think it should be mandatory to specify this option in > plain mode when tablespaces are present. Otherwise, creating a base > backup is liable to create random files all over the place. Obviously, > there would b

Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-01-16 Thread Steeve Lennmark
src/bin/scripts/reindexdb.c src/bin/scripts/vacuumdb.c > 3. How many definitions of atooid() do we have now? > $ git grep '#define atooid' |wc -l 11 I found no obvious .h to include though. -- Steeve Lennmark

Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-01-16 Thread Steeve Lennmark
patch fixes that. -- Steeve Lennmark 0005-pg_basebackup-relocate-tablespace.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-01-09 Thread Steeve Lennmark
On Thu, Jan 9, 2014 at 10:29 PM, Gabriele Bartolini < gabriele.bartol...@2ndquadrant.it> wrote: > Hi Steeve, > > Il 09/01/14 22:10, Steeve Lennmark ha scritto: > > > > That's a much better solution, I attached a patch with the updated code. > > > > #