[HACKERS] Add schema-qualified relnames in constraint error messages.

2016-01-05 Thread Petr Korobeinikov
Hackers, At the moment schemas used as single-level namespaces. It's quite convenient in large databases. But error messages doesn’t contain schema names. I have done a little patch with schema-qualified relation names in error messages that produced by foreign key constraints and triggers. Pat

Re: [HACKERS] Beginner hacker item: Fix to_reg*() input type

2016-01-05 Thread Petr Korobeinikov
2016-01-05 21:04 GMT+03:00 Tom Lane : > (I did make some small adjustments --- in this usage, PG_GETARG_TEXT_PP > is good enough and likely a bit more efficient than PG_GETARG_TEXT_P.) > Also I forgot to bump catalog version up. My mishit.

Re: [HACKERS] Beginner hacker item: Fix to_reg*() input type

2016-01-04 Thread Petr Korobeinikov
> - Modify the functions in regproc.c. Take a look at how other text input > functions work to see what needs to happen here (you'll want to use > text_to_cstring() as part of that.) > > - Modify the appropriate entries in src/include/catalog/pg_proc.h Let me try. `make check` says "All 160 tests

Re: [HACKERS] Comfortably check BackendPID with psql

2015-07-05 Thread Petr Korobeinikov
+1 for Julien's patch.

Re: [HACKERS] psql :: support for \ev viewname and \sv viewname

2015-07-03 Thread Petr Korobeinikov
пт, 3 июля 2015 г. в 19:30, Tom Lane : > So AFAICS, \ev and \sv should just number lines straightforwardly, with > "1" being the first line of the CREATE command text. Am I missing > something? > Fixed. Now both \ev and \sv numbering lines starting with "1". New version attached. As I've alrea

Re: [HACKERS] psql :: support for \ev viewname and \sv viewname

2015-06-06 Thread Petr Korobeinikov
> 1. > make failed with docs > Fixed. > 2. > > \ev vw1 3 > > This syntax is supported. But documentation only says: > \ev [ viewname ] > Missing optional line_number clause > Fixed. Documented. 3. > > strip_lineno_from_objdesc(char *func) > > Can we have parameter name as obj instead of func. >

Re: [HACKERS] psql :: support for \ev viewname and \sv viewname

2015-05-23 Thread Petr Korobeinikov
Just a merge after pgindent run (807b9e0dff663c5da875af7907a5106c0ff90673). psql-ev-sv-support-v3.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] psql :: support for \ev viewname and \sv viewname

2015-05-04 Thread Petr Korobeinikov
Hackers! I'm proposing to add two new subcommands in psql: 1. \ev viewname - edit view definition with external editor (like \ef for function) 2. \sv viewname - show view definition (like \sf for function, for consistency) What's inside: 1. review-ready implementation of \ev and \sv psql subcomma