Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-12 Thread Payal Singh
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, failed Documentation:not tested When running gmake installcheck for regression tests, 2 tests are

Re: [HACKERS] Add CINE for ALTER TABLE ... ADD COLUMN

2015-04-22 Thread Payal Singh
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested Seeing this when trying to apply the patch: Patching file src/backend/co

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-04-22 Thread Payal Singh
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: tested, failed Spec compliant: not tested Documentation:tested, failed Error in postgresql.conf gives the expected result on pg_ctl reload,

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-04-22 Thread Payal Singh
Ah sorry, didn't realize I top posted. I'll test this new one. Payal. On Apr 21, 2015 10:23 PM, "Jan de Visser" wrote: > On April 21, 2015 09:34:51 PM Jan de Visser wrote: > > On April 21, 2015 09:01:14 PM Jan de Visser wrote: > > > On April 21, 2015 07:

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-04-21 Thread Payal Singh
pplied I'm guessing since this is a patch submitted to the commitfest after the current one, am I too early to start reviewing it? Payal Payal Singh, Database Administrator, OmniTI Computer Consulting Inc. Phone: 240.646.0770 x 253 On Thu, Mar 5, 2015 at 4:06 PM, Jim Nasby wrote: > On 3

[HACKERS] Review: Patch FORCE_NULL option for copy COPY in CSV mode

2013-10-31 Thread Payal Singh
ode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("COPY force null only available using COPY FROM"))); === Suggested Changes & Conclusion === The Above mentioned error condition should be corrected. Minor comments and tab changes are upto the author. In all, suggested modifications aside, the patch works well and in my opinion, would be a useful addition to the COPY command. Payal Singh, OmniTi Computer Consulting Inc. Junior Database Architect